Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(268)

Side by Side Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

Issue 2851053002: Fix detached event listener attribute updating. (Closed)
Patch Set: Push Document lookup down Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved. 2 * Copyright (C) 2006, 2007, 2008, 2009 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions are 5 * modification, are permitted provided that the following conditions are
6 * met: 6 * met:
7 * 7 *
8 * * Redistributions of source code must retain the above copyright 8 * * Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * * Redistributions in binary form must reproduce the above 10 * * Redistributions in binary form must reproduce the above
(...skipping 87 matching lines...) Expand 10 before | Expand all | Expand 10 after
98 // Provides access to the underlying handle for GC. Returned 98 // Provides access to the underlying handle for GC. Returned
99 // value is a weak handle and so not guaranteed to stay alive. 99 // value is a weak handle and so not guaranteed to stay alive.
100 v8::Persistent<v8::Object>& ExistingListenerObjectPersistentHandle() { 100 v8::Persistent<v8::Object>& ExistingListenerObjectPersistentHandle() {
101 return listener_.Get(); 101 return listener_.Get();
102 } 102 }
103 103
104 bool HasExistingListenerObject() { return !listener_.IsEmpty(); } 104 bool HasExistingListenerObject() { return !listener_.IsEmpty(); }
105 105
106 void ClearListenerObject(); 106 void ClearListenerObject();
107 107
108 bool BelongsToTheCurrentWorld(ExecutionContext*) const final; 108 bool BelongsToTheCurrentWorld(Document*) const final;
109 109
110 bool IsAttribute() const final { return is_attribute_; } 110 bool IsAttribute() const final { return is_attribute_; }
111 111
112 v8::Isolate* GetIsolate() const { return isolate_; } 112 v8::Isolate* GetIsolate() const { return isolate_; }
113 DOMWrapperWorld& World() const { return *world_; } 113 DOMWrapperWorld& World() const { return *world_; }
114 114
115 DECLARE_VIRTUAL_TRACE(); 115 DECLARE_VIRTUAL_TRACE();
116 DECLARE_VIRTUAL_TRACE_WRAPPERS(); 116 DECLARE_VIRTUAL_TRACE_WRAPPERS();
117 117
118 protected: 118 protected:
(...skipping 32 matching lines...) Expand 10 before | Expand all | Expand 10 after
151 151
152 // nullptr unless this listener belongs to a worker. 152 // nullptr unless this listener belongs to a worker.
153 Member<WorkerGlobalScope> worker_global_scope_; 153 Member<WorkerGlobalScope> worker_global_scope_;
154 154
155 SelfKeepAlive<V8AbstractEventListener> keep_alive_; 155 SelfKeepAlive<V8AbstractEventListener> keep_alive_;
156 }; 156 };
157 157
158 } // namespace blink 158 } // namespace blink
159 159
160 #endif // V8AbstractEventListener_h 160 #endif // V8AbstractEventListener_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698