third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h - Issue 2851053002: Fix detached event listener attribute updating.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

Issue 2851053002: Fix detached event listener attribute updating. (Closed)

Patch Set: Push Document lookup down Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/fast/events/event-listener-detached.html ('k') | third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

diff --git a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

index 0c71436fcbb8a6cddc87705baa12afe4ee78d5e6..ffb815d025bc9688fc984c95c3922a6936a1ce3e 100644

--- a/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

+++ b/third_party/WebKit/Source/bindings/core/v8/V8AbstractEventListener.h

@@ -105,7 +105,7 @@ class CORE_EXPORT V8AbstractEventListener : public EventListener,

void ClearListenerObject();

- bool BelongsToTheCurrentWorld(ExecutionContext*) const final;

+ bool BelongsToTheCurrentWorld(Document*) const final;

bool IsAttribute() const final { return is_attribute_; }