Enable MacOSX native notifications by default

Enable MacOSX native notifications by default

TBR=finnur
BUG=714665
Review-Url: https://codereview.chromium.org/2833993002
Cr-Commit-Position: refs/heads/master@{#466687}
Committed: https://chromium.googlesource.com/chromium/src/+/9b50286f24130476571e2d8e2a5a410e20f9f787

[Miguel Garcia, 2017-04-21 07:06:15]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-21 07:06:38]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-21 08:26:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-21 08:26:20]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[Miguel Garcia, 2017-04-24 15:37:15]

The CQ bit was checked by miguelg@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-24 15:38:03]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Miguel Garcia, 2017-04-24 16:00:33]

miguelg@chromium.org changed reviewers:
+ peter@chromium.org

[Peter Beverloo, 2017-04-24 16:11:17]

lgtm

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notification_interactive_uitest_support.cc
(right):

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_interactive_uitest_support.cc:119:
void NotificationsTest::SetUpDefaultCommandLine(
I think it's more common to override SetUpCommandLine()

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_interactive_uitest_support.cc:123: //
with native notifications.
nit: refer to a bug

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_interactive_uitest_support.cc:125:
command_line->AppendSwitchASCII("disable-features", "NativeNotifications");
#include "chrome/common/chrome_features.h"
#include "content/public/common/content_switches.h"

"disable-features" -> content::kDisableFeatures
"NativeNotifications" -> features::kNativeNotifications.name

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/platform_notification_service_unittest.cc
(right):

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/platform_notification_service_unittest.cc:172:
#elif BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
Ugh. ENABLE_NATIVE_NOTIFICATIONS is enabled for Android but the base::Feature
not yet. Please do follow up with that.

[Miguel Garcia, 2017-04-24 16:15:55]

miguelg@chromium.org changed reviewers:
+ finnur@chromium.org

[Miguel Garcia, 2017-04-24 16:15:55]

+Finnur for service_worker_apitest.cc OWNERS

[Miguel Garcia, 2017-04-24 16:33:33]

Description was changed from

==========
Enable MacOSX native notifications by default

BUG=670624
==========

to

==========
Enable MacOSX native notifications by default

BUG=714665
==========

[commit-bot: I haz the power, 2017-04-24 16:56:15]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-24 16:56:16]

Dry run: This issue passed the CQ dry run.

[Miguel Garcia, 2017-04-24 17:26:05]

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/notification_interactive_uitest_support.cc
(right):

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_interactive_uitest_support.cc:119:
void NotificationsTest::SetUpDefaultCommandLine(
On 2017/04/24 16:11:16, Peter Beverloo wrote:
> I think it's more common to override SetUpCommandLine()

Acknowledged.

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_interactive_uitest_support.cc:123: //
with native notifications.
On 2017/04/24 16:11:16, Peter Beverloo wrote:
> nit: refer to a bug

Done.

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/notification_interactive_uitest_support.cc:125:
command_line->AppendSwitchASCII("disable-features", "NativeNotifications");
On 2017/04/24 16:11:16, Peter Beverloo wrote:
> #include "chrome/common/chrome_features.h"
> #include "content/public/common/content_switches.h"
> 
> "disable-features" -> content::kDisableFeatures
> "NativeNotifications" -> features::kNativeNotifications.name

Done.

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
File chrome/browser/notifications/platform_notification_service_unittest.cc
(right):

https://codereview.chromium.org/2833993002/diff/20001/chrome/browser/notifica...
chrome/browser/notifications/platform_notification_service_unittest.cc:172:
#elif BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
On 2017/04/24 16:11:17, Peter Beverloo wrote:
> Ugh. ENABLE_NATIVE_NOTIFICATIONS is enabled for Android but the base::Feature
> not yet. Please do follow up with that.

Acknowledged.

[Miguel Garcia, 2017-04-24 17:26:24]

Description was changed from

==========
Enable MacOSX native notifications by default

BUG=714665
==========

to

==========
Enable MacOSX native notifications by default

TBR=finnur
BUG=714665
==========

[Miguel Garcia, 2017-04-24 17:26:31]

The CQ bit was checked by miguelg@chromium.org

[Miguel Garcia, 2017-04-24 17:26:31]

The patchset sent to the CQ was uploaded after l-g-t-m from peter@chromium.org
Link to the patchset: https://codereview.chromium.org/2833993002/#ps40001
(title: "review")

[commit-bot: I haz the power, 2017-04-24 17:27:02]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-24 18:13:56]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1493054791585370,
"parent_rev": "d5c6a6d7d856dc18af114a4fbaa1b69eee76cf8e", "commit_rev":
"9b50286f24130476571e2d8e2a5a410e20f9f787"}

[commit-bot: I haz the power, 2017-04-24 18:14:08]

Description was changed from

==========
Enable MacOSX native notifications by default

TBR=finnur
BUG=714665
==========

to

==========
Enable MacOSX native notifications by default

TBR=finnur
BUG=714665

Review-Url: https://codereview.chromium.org/2833993002
Cr-Commit-Position: refs/heads/master@{#466687}
Committed:
https://chromium.googlesource.com/chromium/src/+/9b50286f24130476571e2d8e2a5a...
==========

[commit-bot: I haz the power, 2017-04-24 18:14:09]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/9b50286f24130476571e2d8e2a5a...

[Finnur, 2017-04-25 12:21:46]

LGTM