Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3352)

Unified Diff: chrome/browser/notifications/platform_notification_service_unittest.cc

Issue 2833993002: Enable MacOSX native notifications by default (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/platform_notification_service_unittest.cc
diff --git a/chrome/browser/notifications/platform_notification_service_unittest.cc b/chrome/browser/notifications/platform_notification_service_unittest.cc
index 840d32c9f7e2e0bdb1745317341a3f6e9c058bac..a7ed01980cb9ce9884ff49c81cfaac0125f46931 100644
--- a/chrome/browser/notifications/platform_notification_service_unittest.cc
+++ b/chrome/browser/notifications/platform_notification_service_unittest.cc
@@ -7,6 +7,7 @@
#include <utility>
#include "base/bind.h"
+#include "base/feature_list.h"
#include "base/macros.h"
#include "base/memory/ptr_util.h"
#include "base/run_loop.h"
@@ -21,6 +22,7 @@
#include "chrome/browser/notifications/notification_test_util.h"
#include "chrome/browser/notifications/platform_notification_service_impl.h"
#include "chrome/browser/notifications/stub_notification_platform_bridge.h"
+#include "chrome/common/chrome_features.h"
#include "chrome/test/base/testing_browser_process.h"
#include "chrome/test/base/testing_profile.h"
#include "chrome/test/base/testing_profile_manager.h"
@@ -167,6 +169,16 @@ class PlatformNotificationServiceTest : public testing::Test {
return static_cast<StubNotificationPlatformBridge*>(
g_browser_process->notification_platform_bridge())
->GetNotificationAt(profile_->GetPath().BaseName().value(), 0);
+#elif BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
+ if (base::FeatureList::IsEnabled(features::kNativeNotifications)) {
+ return static_cast<StubNotificationPlatformBridge*>(
+ g_browser_process->notification_platform_bridge())
+ ->GetNotificationAt(profile_->GetPath().BaseName().value(), 0);
+ } else {
+ return static_cast<StubNotificationUIManager*>(
+ g_browser_process->notification_ui_manager())
+ ->GetNotificationAt(0);
+ }
#else
return static_cast<StubNotificationUIManager*>(
g_browser_process->notification_ui_manager())
« no previous file with comments | « chrome/browser/notifications/notification_interactive_uitest_support.cc ('k') | chrome/common/chrome_features.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698