Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(161)

Side by Side Diff: chrome/common/chrome_features.cc

Issue 2833993002: Enable MacOSX native notifications by default (Closed)
Patch Set: review Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_unittest.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/common/chrome_features.h" 5 #include "chrome/common/chrome_features.h"
6 6
7 #include "base/command_line.h" 7 #include "base/command_line.h"
8 #include "chrome/common/chrome_switches.h" 8 #include "chrome/common/chrome_switches.h"
9 #include "extensions/features/features.h" 9 #include "extensions/features/features.h"
10 #include "ppapi/features/features.h" 10 #include "ppapi/features/features.h"
(...skipping 202 matching lines...) Expand 10 before | Expand all | Expand 10 after
213 213
214 #if defined(OS_WIN) 214 #if defined(OS_WIN)
215 // Enables or disables the ModuleDatabase backend for the conflicts UI. 215 // Enables or disables the ModuleDatabase backend for the conflicts UI.
216 const base::Feature kModuleDatabase{"ModuleDatabase", 216 const base::Feature kModuleDatabase{"ModuleDatabase",
217 base::FEATURE_DISABLED_BY_DEFAULT}; 217 base::FEATURE_DISABLED_BY_DEFAULT};
218 #endif 218 #endif
219 219
220 // Enables the use of native notification centers instead of using the Message 220 // Enables the use of native notification centers instead of using the Message
221 // Center for displaying the toasts. 221 // Center for displaying the toasts.
222 #if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS) 222 #if BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
223 #if defined(OS_MACOSX)
224 const base::Feature kNativeNotifications{"NativeNotifications",
225 base::FEATURE_ENABLED_BY_DEFAULT};
226 #else
223 const base::Feature kNativeNotifications{"NativeNotifications", 227 const base::Feature kNativeNotifications{"NativeNotifications",
224 base::FEATURE_DISABLED_BY_DEFAULT}; 228 base::FEATURE_DISABLED_BY_DEFAULT};
225 #endif 229 #endif
230 #endif // BUILDFLAG(ENABLE_NATIVE_NOTIFICATIONS)
226 231
227 // If enabled, the list of content suggestions on the New Tab page will contain 232 // If enabled, the list of content suggestions on the New Tab page will contain
228 // pages that the user downloaded for later use. 233 // pages that the user downloaded for later use.
229 const base::Feature kOfflinePageDownloadSuggestionsFeature{ 234 const base::Feature kOfflinePageDownloadSuggestionsFeature{
230 "NTPOfflinePageDownloadSuggestions", base::FEATURE_ENABLED_BY_DEFAULT}; 235 "NTPOfflinePageDownloadSuggestions", base::FEATURE_ENABLED_BY_DEFAULT};
231 236
232 // Enables Permissions Blacklisting via Safe Browsing. 237 // Enables Permissions Blacklisting via Safe Browsing.
233 const base::Feature kPermissionsBlacklist{ 238 const base::Feature kPermissionsBlacklist{
234 "PermissionsBlacklist", base::FEATURE_DISABLED_BY_DEFAULT}; 239 "PermissionsBlacklist", base::FEATURE_DISABLED_BY_DEFAULT};
235 240
(...skipping 100 matching lines...) Expand 10 before | Expand all | Expand 10 after
336 return base::FeatureList::IsEnabled(features::kPrefService) || 341 return base::FeatureList::IsEnabled(features::kPrefService) ||
337 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES) 342 #if BUILDFLAG(ENABLE_PACKAGE_MASH_SERVICES)
338 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII( 343 base::CommandLine::ForCurrentProcess()->GetSwitchValueASCII(
339 switches::kMusConfig) == switches::kMash; 344 switches::kMusConfig) == switches::kMash;
340 #else 345 #else
341 false; 346 false;
342 #endif 347 #endif
343 } 348 }
344 349
345 } // namespace features 350 } // namespace features
OLDNEW
« no previous file with comments | « chrome/browser/notifications/platform_notification_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698