Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(605)

Issue 2809923002: Unify implementations of Map handles vectors and lists (Closed)

Created:
3 years, 8 months ago by danno
Modified:
3 years, 7 months ago
Reviewers:
Franzi, Jakob Kummerow
CC:
v8-reviews_googlegroups.com
Target Ref:
refs/heads/master
Project:
v8
Visibility:
Public.

Description

Unify implementations of Map handles vectors and lists This CL introduces a new type, MapHandles, which is a STL vector of Handle<Map>. It is now used everywhere where lists of Handle<Maps> are required, replacing usages of V8's internal List type. Also-By: franzih@chromium.org BUG=v8:6333, v8:6325 LOG=N Review-Url: https://codereview.chromium.org/2809923002 Cr-Commit-Position: refs/heads/master@{#45211} Committed: https://chromium.googlesource.com/v8/v8/+/fc274fbe99e5c254bb4568d497dd4b8e6e7433e9

Patch Set 1 #

Patch Set 2 : WIP: MapList --> MapHandleVector #

Patch Set 3 : Update to latest #

Patch Set 4 : Marge franzi's changes #

Patch Set 5 : Fix bug #

Patch Set 6 : Latest #

Patch Set 7 : Format #

Total comments: 4

Patch Set 8 : Review feedback #

Patch Set 9 : Style nit #

Total comments: 4

Patch Set 10 : Review feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+211 lines, -211 lines) Patch
M src/compiler.cc View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/access-info.h View 1 2 3 4 5 6 5 chunks +16 lines, -18 lines 0 comments Download
M src/compiler/access-info.cc View 1 2 3 4 5 6 7 16 chunks +35 lines, -34 lines 0 comments Download
M src/compiler/js-native-context-specialization.h View 1 2 3 4 5 6 5 chunks +7 lines, -7 lines 0 comments Download
M src/compiler/js-native-context-specialization.cc View 1 2 3 4 5 6 7 8 9 16 chunks +29 lines, -29 lines 0 comments Download
M src/crankshaft/hydrogen.cc View 1 2 3 4 5 6 7 5 chunks +14 lines, -12 lines 0 comments Download
M src/feedback-vector.h View 1 2 3 4 5 6 6 chunks +8 lines, -8 lines 0 comments Download
M src/feedback-vector.cc View 1 2 3 4 5 6 5 chunks +9 lines, -8 lines 0 comments Download
M src/ic/ic.h View 1 2 3 4 5 6 7 5 chunks +8 lines, -8 lines 0 comments Download
M src/ic/ic.cc View 1 2 3 4 5 6 7 8 9 16 chunks +61 lines, -62 lines 0 comments Download
M src/objects.h View 1 2 3 4 5 6 7 8 9 2 chunks +2 lines, -1 line 0 comments Download
M src/objects.cc View 1 2 3 4 5 6 7 8 9 1 chunk +4 lines, -5 lines 0 comments Download
M src/type-info.cc View 1 2 3 4 5 6 7 1 chunk +4 lines, -4 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 1 2 3 4 5 6 7 4 chunks +7 lines, -8 lines 0 comments Download
M test/cctest/test-field-type-tracking.cc View 1 2 3 4 5 6 2 chunks +6 lines, -6 lines 0 comments Download

Messages

Total messages: 34 (26 generated)
danno
PTAL
3 years, 7 months ago (2017-05-02 13:45:40 UTC) #13
Franzi
LGTM with nit. Thanks! https://codereview.chromium.org/2809923002/diff/120001/src/compiler/access-info.cc File src/compiler/access-info.cc (right): https://codereview.chromium.org/2809923002/diff/120001/src/compiler/access-info.cc#newcode539 src/compiler/access-info.cc:539: for (auto map : maps) ...
3 years, 7 months ago (2017-05-02 16:29:32 UTC) #14
danno
+jkummerow for ic directory review https://codereview.chromium.org/2809923002/diff/120001/src/compiler/access-info.cc File src/compiler/access-info.cc (right): https://codereview.chromium.org/2809923002/diff/120001/src/compiler/access-info.cc#newcode539 src/compiler/access-info.cc:539: for (auto map : ...
3 years, 7 months ago (2017-05-03 15:10:30 UTC) #19
danno
+jkummerow for ic directory review https://codereview.chromium.org/2809923002/diff/120001/src/compiler/access-info.cc File src/compiler/access-info.cc (right): https://codereview.chromium.org/2809923002/diff/120001/src/compiler/access-info.cc#newcode539 src/compiler/access-info.cc:539: for (auto map : ...
3 years, 7 months ago (2017-05-03 15:10:30 UTC) #20
Jakob Kummerow
LGTM with nits. https://codereview.chromium.org/2809923002/diff/160001/src/ic/ic.cc File src/ic/ic.cc (left): https://codereview.chromium.org/2809923002/diff/160001/src/ic/ic.cc#oldcode1429 src/ic/ic.cc:1429: // Filter out deprecated maps to ...
3 years, 7 months ago (2017-05-05 15:28:39 UTC) #27
danno
Feedback addressed, landing. https://codereview.chromium.org/2809923002/diff/160001/src/ic/ic.cc File src/ic/ic.cc (left): https://codereview.chromium.org/2809923002/diff/160001/src/ic/ic.cc#oldcode1429 src/ic/ic.cc:1429: // Filter out deprecated maps to ...
3 years, 7 months ago (2017-05-09 21:29:03 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2809923002/180001
3 years, 7 months ago (2017-05-09 21:29:20 UTC) #31
commit-bot: I haz the power
3 years, 7 months ago (2017-05-09 22:36:11 UTC) #34
Message was sent while issue was closed.
Committed patchset #10 (id:180001) as
https://chromium.googlesource.com/v8/v8/+/fc274fbe99e5c254bb4568d497dd4b8e6e7...

Powered by Google App Engine
This is Rietveld 408576698