Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1793)

Unified Diff: src/ic/ic.h

Issue 2809923002: Unify implementations of Map handles vectors and lists (Closed)
Patch Set: Review feedback Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/feedback-vector.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/ic/ic.h
diff --git a/src/ic/ic.h b/src/ic/ic.h
index 4649bc0b0e42591c3b5d233b4f69b3c6769c3343..b75a73d912121ea365cc51094bfc3f13a1d66a9c 100644
--- a/src/ic/ic.h
+++ b/src/ic/ic.h
@@ -96,7 +96,7 @@ class IC {
void ConfigureVectorState(Handle<Name> name, Handle<Map> map,
Handle<Object> handler);
// Configure the vector for POLYMORPHIC.
- void ConfigureVectorState(Handle<Name> name, MapHandleList* maps,
+ void ConfigureVectorState(Handle<Name> name, MapHandles const& maps,
List<Handle<Object>>* handlers);
char TransitionMarkFromState(IC::State state);
@@ -164,16 +164,16 @@ class IC {
}
}
- void TargetMaps(MapHandleList* list) {
+ void TargetMaps(MapHandles* list) {
FindTargetMaps();
- for (int i = 0; i < target_maps_.length(); i++) {
- list->Add(target_maps_.at(i));
+ for (Handle<Map> map : target_maps_) {
+ list->push_back(map);
}
}
Map* FirstTargetMap() {
FindTargetMaps();
- return target_maps_.length() > 0 ? *target_maps_.at(0) : NULL;
+ return !target_maps_.empty() ? *target_maps_[0] : NULL;
}
Handle<FeedbackVector> vector() const { return nexus()->vector_handle(); }
@@ -223,7 +223,7 @@ class IC {
MaybeHandle<Object> maybe_handler_;
ExtraICState extra_ic_state_;
- MapHandleList target_maps_;
+ MapHandles target_maps_;
bool target_maps_set_;
const char* slow_stub_reason_;
@@ -328,7 +328,7 @@ class KeyedLoadIC : public LoadIC {
Handle<Object> LoadElementHandler(Handle<Map> receiver_map);
- void LoadElementPolymorphicHandlers(MapHandleList* receiver_maps,
+ void LoadElementPolymorphicHandlers(MapHandles* receiver_maps,
List<Handle<Object>>* handlers);
};
@@ -414,7 +414,7 @@ class KeyedStoreIC : public StoreIC {
Handle<Object> StoreElementHandler(Handle<Map> receiver_map,
KeyedAccessStoreMode store_mode);
- void StoreElementPolymorphicHandlers(MapHandleList* receiver_maps,
+ void StoreElementPolymorphicHandlers(MapHandles* receiver_maps,
List<Handle<Object>>* handlers,
KeyedAccessStoreMode store_mode);
« no previous file with comments | « src/feedback-vector.cc ('k') | src/ic/ic.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698