src/compiler.cc - Issue 2809923002: Unify implementations of Map handles vectors and lists

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/compiler.cc

Issue 2809923002: Unify implementations of Map handles vectors and lists (Closed)

Patch Set: Review feedback Created 3 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/compiler.cc

diff --git a/src/compiler.cc b/src/compiler.cc

index 2f841db9ba5f68451efdb33b752a766d904f5d10..f2f86ddd398d0df161c6d8a0ff757a1de20e7f8a 100644

--- a/src/compiler.cc

+++ b/src/compiler.cc

@@ -232,7 +232,7 @@ void CompilationJob::RegisterWeakObjectsInOptimizedCode(Handle<Code> code) {

// TODO(turbofan): Move this to pipeline.cc once Crankshaft dies.

Isolate* const isolate = code->GetIsolate();

DCHECK(code->is_optimized_code());

- std::vector<Handle<Map>> maps;

+ MapHandles maps;

std::vector<Handle<HeapObject>> objects;

{

DisallowHeapAllocation no_gc;

« no previous file with comments | « no previous file | src/compiler/access-info.h » ('j') | no next file with comments »