Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Side by Side Diff: ios/web/navigation/crw_session_controller.h

Issue 2720613005: Refactor serialisation of openerId & openerNavigationIndex. (Closed)
Patch Set: Fix CRWSessionController's initializer comment. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 The Chromium Authors. All rights reserved. 1 // Copyright 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_ 5 #ifndef IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_
6 #define IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_ 6 #define IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_
7 7
8 #import <Foundation/Foundation.h> 8 #import <Foundation/Foundation.h>
9 #include <vector> 9 #include <vector>
10 10
(...skipping 25 matching lines...) Expand all
36 // The index of the pending item if it is in |items|, or -1 if |pendingItem| 36 // The index of the pending item if it is in |items|, or -1 if |pendingItem|
37 // corresponds with a new navigation (created by addPendingItem:). 37 // corresponds with a new navigation (created by addPendingItem:).
38 @property(nonatomic, readwrite, assign) NSInteger pendingItemIndex; 38 @property(nonatomic, readwrite, assign) NSInteger pendingItemIndex;
39 @property(nonatomic, copy) NSString* windowName; 39 @property(nonatomic, copy) NSString* windowName;
40 // Indicates whether the page was opened by DOM (e.g. with |window.open| 40 // Indicates whether the page was opened by DOM (e.g. with |window.open|
41 // JavaScript call or by clicking a link with |_blank| target). 41 // JavaScript call or by clicking a link with |_blank| target).
42 @property(nonatomic, readonly, getter=isOpenedByDOM) BOOL openedByDOM; 42 @property(nonatomic, readonly, getter=isOpenedByDOM) BOOL openedByDOM;
43 @property(nonatomic, readonly, strong) 43 @property(nonatomic, readonly, strong)
44 CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager; 44 CRWSessionCertificatePolicyManager* sessionCertificatePolicyManager;
45 @property(nonatomic, assign) NSTimeInterval lastVisitedTimestamp; 45 @property(nonatomic, assign) NSTimeInterval lastVisitedTimestamp;
46 @property(nonatomic, readonly, copy) NSString* openerId;
47 @property(nonatomic, readonly, assign) NSInteger openerNavigationIndex;
48 46
49 // The list of CRWSessionEntries in |_entries|'s NavigationItemImpls. 47 // The list of CRWSessionEntries in |_entries|'s NavigationItemImpls.
50 @property(nonatomic, readonly) web::NavigationItemList items; 48 @property(nonatomic, readonly) web::NavigationItemList items;
51 // The current NavigationItem. During a pending navigation, returns the 49 // The current NavigationItem. During a pending navigation, returns the
52 // NavigationItem for that navigation. If a transient NavigationItem exists, 50 // NavigationItem for that navigation. If a transient NavigationItem exists,
53 // this NavigationItem will be returned. 51 // this NavigationItem will be returned.
54 @property(nonatomic, readonly) web::NavigationItemImpl* currentItem; 52 @property(nonatomic, readonly) web::NavigationItemImpl* currentItem;
55 // Returns the NavigationItem whose URL should be displayed to the user. 53 // Returns the NavigationItem whose URL should be displayed to the user.
56 @property(nonatomic, readonly) web::NavigationItemImpl* visibleItem; 54 @property(nonatomic, readonly) web::NavigationItemImpl* visibleItem;
57 // Returns the NavigationItem corresponding to a load for which no data has yet 55 // Returns the NavigationItem corresponding to a load for which no data has yet
(...skipping 94 matching lines...) Expand 10 before | Expand all | Expand 10 after
152 // same-document navigation. Entries can be passed in any order. 150 // same-document navigation. Entries can be passed in any order.
153 - (BOOL)isSameDocumentNavigationBetweenItem:(web::NavigationItem*)firstItem 151 - (BOOL)isSameDocumentNavigationBetweenItem:(web::NavigationItem*)firstItem
154 andItem:(web::NavigationItem*)secondItem; 152 andItem:(web::NavigationItem*)secondItem;
155 153
156 // Returns the index of |item| in |items|. 154 // Returns the index of |item| in |items|.
157 - (NSInteger)indexOfItem:(const web::NavigationItem*)item; 155 - (NSInteger)indexOfItem:(const web::NavigationItem*)item;
158 156
159 @end 157 @end
160 158
161 #endif // IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_ 159 #endif // IOS_WEB_NAVIGATION_CRW_SESSION_CONTROLLER_H_
OLDNEW
« no previous file with comments | « ios/chrome/browser/tabs/tab_unittest.mm ('k') | ios/web/navigation/crw_session_controller.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698