Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Unified Diff: ios/chrome/browser/tabs/tab_model.mm

Issue 2720613005: Refactor serialisation of openerId & openerNavigationIndex. (Closed)
Patch Set: Fix CRWSessionController's initializer comment. Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_model_unittest.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/tabs/tab_model.mm
diff --git a/ios/chrome/browser/tabs/tab_model.mm b/ios/chrome/browser/tabs/tab_model.mm
index 310c4a190e9eabfbffdca09249af53cd9bfa5c49..59558dc28447387c06cd6b179542cc6f9e360903 100644
--- a/ios/chrome/browser/tabs/tab_model.mm
+++ b/ios/chrome/browser/tabs/tab_model.mm
@@ -121,13 +121,11 @@ void CleanCertificatePolicyCache(
// checking the associated Tab tabId (should be removed once the opener
// is passed to the insertTab:atIndex: and replaceTab:withTab: methods).
Tab* GetOpenerForTab(id<NSFastEnumeration> tabs, Tab* tab) {
- NSString* opener_id =
- [tab navigationManager]->GetSessionController().openerId;
- if (!opener_id)
+ if (!tab.openerID)
return nullptr;
for (Tab* currentTab in tabs) {
- if ([opener_id isEqualToString:currentTab.tabId])
+ if ([tab.openerID isEqualToString:currentTab.tabId])
return currentTab;
}
« no previous file with comments | « ios/chrome/browser/tabs/tab.mm ('k') | ios/chrome/browser/tabs/tab_model_unittest.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698