Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2716413002: [Payment Request] Replacing more iOS strings with components strings (Closed)

Created:
3 years, 9 months ago by Moe
Modified:
3 years, 9 months ago
CC:
chromium-reviews, mahmadi+paymentsioswatch_chromium.org, pkl (ping after 24h if needed), gogerald+paymentswatch_chromium.org, rouslan+payments_chromium.org, marq+watch_chromium.org, noyau+watch_chromium.org, mahmadi+paymentswatch_chromium.org, srahim+watch_chromium.org, sebsg+paymentswatch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Payment Request] Replacing more iOS strings with components strings BUG=602666 Review-Url: https://codereview.chromium.org/2716413002 Cr-Commit-Position: refs/heads/master@{#453502} Committed: https://chromium.googlesource.com/chromium/src/+/167a891703b0811668c2a6d655db82f10e4128b2

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+40 lines, -64 lines) Patch
M components/payments_strings.grdp View 3 chunks +10 lines, -1 line 0 comments Download
M ios/chrome/app/strings/ios_strings.grd View 1 chunk +0 lines, -30 lines 0 comments Download
M ios/chrome/browser/payments/payment_items_display_view_controller.mm View 1 3 chunks +4 lines, -6 lines 0 comments Download
M ios/chrome/browser/payments/payment_items_display_view_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_method_selection_view_controller.mm View 2 chunks +3 lines, -4 lines 0 comments Download
M ios/chrome/browser/payments/payment_method_selection_view_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_request_error_view_controller.mm View 1 chunk +1 line, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_request_error_view_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/payment_request_view_controller.mm View 1 5 chunks +11 lines, -12 lines 0 comments Download
M ios/chrome/browser/payments/payment_request_view_controller_unittest.mm View 2 chunks +2 lines, -1 line 0 comments Download
M ios/chrome/browser/payments/shipping_address_selection_view_controller.mm View 2 chunks +2 lines, -4 lines 0 comments Download
M ios/chrome/browser/payments/shipping_option_selection_view_controller.mm View 1 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 15 (10 generated)
Moe
Hi Rouslan, Please take a look at this CL.
3 years, 9 months ago (2017-02-27 18:07:18 UTC) #2
please use gerrit instead
rs lgtm
3 years, 9 months ago (2017-02-27 18:24:51 UTC) #3
Moe
On 2017/02/27 18:24:51, rouslan wrote: > rs lgtm Thanks.
3 years, 9 months ago (2017-02-28 04:48:20 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2716413002/20001
3 years, 9 months ago (2017-02-28 04:48:58 UTC) #11
commit-bot: I haz the power
3 years, 9 months ago (2017-02-28 04:59:33 UTC) #15
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/167a891703b0811668c2a6d655db...

Powered by Google App Engine
This is Rietveld 408576698