ios/chrome/browser/payments/shipping_address_selection_view_controller.mm - Issue 2716413002: [Payment Request] Replacing more iOS strings with components strings

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/payments/shipping_address_selection_view_controller.mm

Issue 2716413002: [Payment Request] Replacing more iOS strings with components strings (Closed)

Patch Set: rebase Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ios/chrome/browser/payments/payment_request_view_controller_unittest.mm ('k') | ios/chrome/browser/payments/shipping_option_selection_view_controller.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ios/chrome/browser/payments/shipping_address_selection_view_controller.mm

diff --git a/ios/chrome/browser/payments/shipping_address_selection_view_controller.mm b/ios/chrome/browser/payments/shipping_address_selection_view_controller.mm

index cbef0f400a425e5d9b9261534f46b5a5745c8a81..b43ad8f95114f0e56b05a883a401d9a0240a56ec 100644

--- a/ios/chrome/browser/payments/shipping_address_selection_view_controller.mm

+++ b/ios/chrome/browser/payments/shipping_address_selection_view_controller.mm

@@ -109,8 +109,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

if (_pending) {

StatusItem* statusItem = [[StatusItem alloc] initWithType:ItemTypeSpinner];

- statusItem.text =

- l10n_util::GetNSString(IDS_IOS_PAYMENT_REQUEST_CHECKING_LABEL);

+ statusItem.text = l10n_util::GetNSString(IDS_PAYMENTS_CHECKING_OPTION);

[model addItem:statusItem

toSectionWithIdentifier:SectionIdentifierShippingAddress];

return;

@@ -146,8 +145,7 @@ typedef NS_ENUM(NSInteger, ItemType) {

PaymentsTextItem* addShippingAddress =

[[PaymentsTextItem alloc] initWithType:ItemTypeAddShippingAddress];

- addShippingAddress.text = l10n_util::GetNSString(

- IDS_IOS_PAYMENT_REQUEST_SHIPPING_ADDRESS_SELECTION_ADD_BUTTON);

+ addShippingAddress.text = l10n_util::GetNSString(IDS_PAYMENTS_ADD_ADDRESS);

addShippingAddress.image = NativeImage(IDR_IOS_PAYMENTS_ADD);

addShippingAddress.accessibilityTraits |= UIAccessibilityTraitButton;

[model addItem:addShippingAddress