Remove -insertTabWithWebState:atIndex: from TabModel.

Remove -insertTabWithWebState:atIndex: from TabModel.

The method -insertTabWithWebState:atIndex: was used by TabModelTest but
-insertTabWithURL:referrer:transition:opener:openedByDOM:atIndex:... is
enough to implement all the tests, so modify them to use that method.

Introduce a new method -insertTabWithNavigationItems:... that is used
to introduce a new Tab with history restored from a saved session and
use it from tab_restore_service_delegate_impl_ios.mm.

BUG=620083, 687207

[sdefresne, 2017-02-24 17:49:39]

Patchset #1 (id:1) has been deleted

[sdefresne, 2017-02-24 17:49:51]

sdefresne@chromium.org changed reviewers:
+ rohitrao@chromium.org

[sdefresne, 2017-02-24 17:49:52]

Please take a look.

[sdefresne, 2017-03-02 03:19:39]

rohitrao: ping

[sdefresne, 2017-03-02 05:25:25]

Description was changed from

==========
Remove -insertTabWithWebState:atIndex: from TabModel.

The method -insertTabWithWebState:atIndex: was used by TabModelTest but
-insertOrUpdateTabWithLoadParams:windowName:opener:openedByDOM:... is
enough to implement all the tests, so modify them to use that method.

Introduce a new method -insertTabWithNavigationItems:... that is used
to introduce a new Tab with history restored from a saved session and
use it from tab_restore_service_delegate_impl_ios.mm.

BUG=620083,687207
==========

to

==========
Remove -insertTabWithWebState:atIndex: from TabModel.

The method -insertTabWithWebState:atIndex: was used by TabModelTest but
-insertTabWithURL:referrer:transition:opener:openedByDOM:atIndex:... is
enough to implement all the tests, so modify them to use that method.

Introduce a new method -insertTabWithNavigationItems:... that is used
to introduce a new Tab with history restored from a saved session and
use it from tab_restore_service_delegate_impl_ios.mm.

BUG=620083,687207
==========

[sdefresne, 2017-03-02 05:34:28]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 05:35:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-02 05:36:23]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 05:37:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-02 05:38:07]

Patchset #2 (id:40001) has been deleted

[commit-bot: I haz the power, 2017-03-02 08:25:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 08:25:33]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[rohitrao (ping after 24h), 2017-03-02 18:28:29]

At a high level, do we want to be moving away from the webstate-based insert
methods, or should we actually be moving towards them?

How does this fit into the larger plan of getting rid of TabModel?  Does this
change help us move towards that goal?

[sdefresne, 2017-03-02 23:32:58]

As discussed offline, I'm closing this CL and sending two separates CLs
corresponding to the fix in the observer bridge and to the cleanup of the unit
tests.