Remove Tab -currentNavigationItem.

Remove Tab -currentNavigationItem.

This returns CRWSessionController -currentEntry which should not be
used. Fix all direct calls in Tab (but leave the call in Tab -url as
it requires fixing all individual clients) by calling the correct
method on the WebState NavigationManager.

BUG=620465
Review-Url: https://codereview.chromium.org/2724103005
Cr-Commit-Position: refs/heads/master@{#455136}
Committed: https://chromium.googlesource.com/chromium/src/+/79b998012d075d544199668fa85fe3bd07c34d7f

[sdefresne, 2017-03-02 22:02:44]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-03-02 22:02:55]

sdefresne@chromium.org changed reviewers:
+ eugenebut@chromium.org, rohitrao@chromium.org

[sdefresne, 2017-03-02 22:02:56]

Please take a look.

[commit-bot: I haz the power, 2017-03-02 22:03:22]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-02 22:17:46]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-02 22:17:47]

Dry run: This issue passed the CQ dry run.

[Eugene But (OOO till 7-30), 2017-03-02 22:52:14]

lgtm

[sdefresne, 2017-03-02 23:43:59]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[sdefresne, 2017-03-02 23:44:12]

Patchset #2 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-03-02 23:44:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[sdefresne, 2017-03-02 23:45:08]

The CQ bit was checked by sdefresne@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-02 23:45:44]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-03 00:00:33]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-03 00:00:34]

Dry run: This issue passed the CQ dry run.

[sdefresne, 2017-03-06 22:35:09]

rohitrao: ping

[rohitrao (ping after 24h), 2017-03-07 14:00:54]

lgtm but this CL changes from currentItem to a variety of calls (GetPendingItem,
GetVisibleItem, GetLastCommittedItem, etc).  Did @eugenebut verify that we're
using the proper calls?

[Eugene But (OOO till 7-30), 2017-03-07 16:26:25]

> Did @eugenebut verify that we're using the proper calls?
Yes

[rohitrao (ping after 24h), 2017-03-07 16:27:34]

On 2017/03/07 16:26:25, Eugene But wrote:
> > Did @eugenebut verify that we're using the proper calls?
> Yes

Great, thanks!

[sdefresne, 2017-03-07 17:51:10]

The CQ bit was checked by sdefresne@chromium.org

[sdefresne, 2017-03-07 17:51:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/2724103005/#ps40001
(title: "Rebase.")

[commit-bot: I haz the power, 2017-03-07 17:51:59]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-07 18:14:06]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1488909070640860,
"parent_rev": "a4fe824eb02d34107126ae84afe2edaff7c3c3c8", "commit_rev":
"79b998012d075d544199668fa85fe3bd07c34d7f"}

[commit-bot: I haz the power, 2017-03-07 18:14:44]

Description was changed from

==========
Remove Tab -currentNavigationItem.

This returns CRWSessionController -currentEntry which should not be
used. Fix all direct calls in Tab (but leave the call in Tab -url as
it requires fixing all individual clients) by calling the correct
method on the WebState NavigationManager.

BUG=620465
==========

to

==========
Remove Tab -currentNavigationItem.

This returns CRWSessionController -currentEntry which should not be
used. Fix all direct calls in Tab (but leave the call in Tab -url as
it requires fixing all individual clients) by calling the correct
method on the WebState NavigationManager.

BUG=620465

Review-Url: https://codereview.chromium.org/2724103005
Cr-Commit-Position: refs/heads/master@{#455136}
Committed:
https://chromium.googlesource.com/chromium/src/+/79b998012d075d544199668fa85f...
==========

[commit-bot: I haz the power, 2017-03-07 18:14:47]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/79b998012d075d544199668fa85f...