ios/chrome/browser/tabs/tab.mm - Issue 2712743008: Remove -insertTabWithWebState:atIndex: from TabModel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab.mm

Issue 2712743008: Remove -insertTabWithWebState:atIndex: from TabModel. (Closed)

Patch Set: Rebase. Created 3 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab.mm

diff --git a/ios/chrome/browser/tabs/tab.mm b/ios/chrome/browser/tabs/tab.mm

index 10e41e5cf9521713eab0772ee0364bb7293306bb..0b301957644e37a52c983a4dbaee1e2a6c7cc5f0 100644

--- a/ios/chrome/browser/tabs/tab.mm

+++ b/ios/chrome/browser/tabs/tab.mm

@@ -903,7 +903,7 @@ void TabInfoBarObserver::OnInfoBarReplaced(infobars::InfoBar* old_infobar,

- (void)replaceHistoryWithNavigations:

(const std::vector<sessions::SerializedNavigationEntry>&)navigations

currentIndex:(NSInteger)currentIndex {

- std::vector<std::unique_ptr<web::NavigationItem>> items =

+ web::ScopedNavigationItemList items =

sessions::IOSSerializedNavigationBuilder::ToNavigationItems(navigations);

[self navigationManagerImpl]->ReplaceSessionHistory(std::move(items),

currentIndex);