Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2)

Issue 2711343002: Remove unused notification kTabModelUserNavigatedNavigation. (Closed)

Created:
3 years, 9 months ago by sdefresne
Modified:
3 years, 9 months ago
CC:
chromium-reviews, marq+watch_chromium.org, pkl (ping after 24h if needed), noyau+watch_chromium.org, sdefresne+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove unused notification kTabModelUserNavigatedNavigation. This notification is sent but no code register to receive it so removing it in the hope that no code register to receive all the notifications from Tabs (as -addObserver:selector:name:object: accepts a nil name and will invoke the selector without filtering). BUG=320877 Review-Url: https://codereview.chromium.org/2711343002 Cr-Commit-Position: refs/heads/master@{#454398} Committed: https://chromium.googlesource.com/chromium/src/+/d5080b74e8ca39517536fc92b3ff78cfbe2a0b3e

Patch Set 1 #

Patch Set 2 : Rebase. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -13 lines) Patch
M ios/chrome/browser/tabs/tab.mm View 1 4 chunks +2 lines, -10 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M ios/chrome/browser/tabs/tab_model.mm View 1 1 chunk +0 lines, -1 line 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 13 (9 generated)
sdefresne
Please take a look.
3 years, 9 months ago (2017-02-24 10:54:56 UTC) #2
rohitrao (ping after 24h)
lgtm One down!
3 years, 9 months ago (2017-02-24 13:45:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711343002/20001
3 years, 9 months ago (2017-03-02 22:00:37 UTC) #10
commit-bot: I haz the power
3 years, 9 months ago (2017-03-02 22:10:21 UTC) #13
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/d5080b74e8ca39517536fc92b3ff...

Powered by Google App Engine
This is Rietveld 408576698