Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(721)

Issue 2711873003: [Web Payments] Re-add extra view in the footer. (Closed)

Created:
3 years, 10 months ago by anthonyvd
Modified:
3 years, 10 months ago
Reviewers:
Mathieu
CC:
chromium-reviews, gogerald+paymentswatch_chromium.org, mahmadi+paymentswatch_chromium.org, rouslan+payments_chromium.org, sebsg+paymentswatch_chromium.org, tfarina
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Web Payments] Re-add extra view in the footer. BUG=679835 Review-Url: https://codereview.chromium.org/2711873003 Cr-Commit-Position: refs/heads/master@{#452526} Committed: https://chromium.googlesource.com/chromium/src/+/33c677f9166e1cc0343712a35b5896aaeeb625c5

Patch Set 1 #

Total comments: 2

Patch Set 2 : Change CreateExtraView to CreateExtraFooterView #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -20 lines) Patch
M chrome/browser/ui/views/payments/editor_view_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/editor_view_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.h View 1 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_method_view_controller.cc View 1 1 chunk +2 lines, -1 line 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.h View 1 2 chunks +1 line, -4 lines 0 comments Download
M chrome/browser/ui/views/payments/payment_request_sheet_controller.cc View 1 3 chunks +11 lines, -7 lines 0 comments Download
M components/payments/payment_request.h View 1 chunk +3 lines, -1 line 0 comments Download
M components/payments/payment_request.cc View 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 11 (5 generated)
anthonyvd
Hi Math, can you PTAL at this CL that addresses your post-land comments on https://codereview.chromium.org/2695653004/ ...
3 years, 10 months ago (2017-02-23 16:18:38 UTC) #2
Mathieu
Thanks for the quick turnaround! https://codereview.chromium.org/2711873003/diff/1/chrome/browser/ui/views/payments/editor_view_controller.h File chrome/browser/ui/views/payments/editor_view_controller.h (right): https://codereview.chromium.org/2711873003/diff/1/chrome/browser/ui/views/payments/editor_view_controller.h#newcode96 chrome/browser/ui/views/payments/editor_view_controller.h:96: std::unique_ptr<views::View> CreateExtraView() override; optional ...
3 years, 10 months ago (2017-02-23 16:22:03 UTC) #3
Mathieu
lgtm
3 years, 10 months ago (2017-02-23 16:22:08 UTC) #4
anthonyvd
https://codereview.chromium.org/2711873003/diff/1/chrome/browser/ui/views/payments/editor_view_controller.h File chrome/browser/ui/views/payments/editor_view_controller.h (right): https://codereview.chromium.org/2711873003/diff/1/chrome/browser/ui/views/payments/editor_view_controller.h#newcode96 chrome/browser/ui/views/payments/editor_view_controller.h:96: std::unique_ptr<views::View> CreateExtraView() override; On 2017/02/23 at 16:22:03, Mathieu Perreault ...
3 years, 10 months ago (2017-02-23 16:27:34 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2711873003/20001
3 years, 10 months ago (2017-02-23 16:28:01 UTC) #8
commit-bot: I haz the power
3 years, 10 months ago (2017-02-23 17:12:02 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/33c677f9166e1cc0343712a35b58...

Powered by Google App Engine
This is Rietveld 408576698