Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3372)

Unified Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

Issue 2711873003: [Web Payments] Re-add extra view in the footer. (Closed)
Patch Set: Change CreateExtraView to CreateExtraFooterView Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
diff --git a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
index ae91215f09ee2bb51e8c6f6153afc309f29297e2..343ca71c5910b9073b7e304d5ca63af98b38e198 100644
--- a/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
+++ b/chrome/browser/ui/views/payments/payment_request_sheet_controller.cc
@@ -25,7 +25,8 @@ PaymentRequestSheetController::CreatePrimaryButton() {
return nullptr;
}
-std::unique_ptr<views::View> PaymentRequestSheetController::CreateExtraView() {
+std::unique_ptr<views::View>
+PaymentRequestSheetController::CreateExtraFooterView() {
return nullptr;
}
@@ -90,8 +91,16 @@ std::unique_ptr<views::View> PaymentRequestSheetController::CreateFooterView() {
columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
0, views::GridLayout::USE_PREF, 0, 0);
+ // The horizontal distance between the right/left edges of the dialog and the
+ // elements.
+ constexpr int kFooterHorizontalInset = 16;
+ // The vertical distance between footer elements and the top/bottom border
+ // (the bottom border is the edge of the dialog).
+ constexpr int kFooterVerticalInset = 16;
+ layout->SetInsets(kFooterVerticalInset, kFooterHorizontalInset,
+ kFooterVerticalInset, kFooterHorizontalInset);
layout->StartRow(0, 0);
- std::unique_ptr<views::View> extra_view = CreateExtraView();
+ std::unique_ptr<views::View> extra_view = CreateExtraFooterView();
if (extra_view)
layout->AddView(extra_view.release());
else
@@ -118,9 +127,4 @@ std::unique_ptr<views::View> PaymentRequestSheetController::CreateFooterView() {
return container;
}
-std::unique_ptr<views::View>
-PaymentRequestSheetController::CreateLeadingFooterView() {
- return base::MakeUnique<views::View>();
-}
-
} // namespace payments
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_sheet_controller.h ('k') | components/payments/payment_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698