Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Side by Side Diff: chrome/browser/ui/views/payments/payment_request_sheet_controller.cc

Issue 2711873003: [Web Payments] Re-add extra view in the footer. (Closed)
Patch Set: Change CreateExtraView to CreateExtraFooterView Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2017 The Chromium Authors. All rights reserved. 1 // Copyright 2017 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/views/payments/payment_request_sheet_controller.h" 5 #include "chrome/browser/ui/views/payments/payment_request_sheet_controller.h"
6 6
7 #include "chrome/browser/ui/views/payments/payment_request_dialog_view.h" 7 #include "chrome/browser/ui/views/payments/payment_request_dialog_view.h"
8 #include "chrome/browser/ui/views/payments/payment_request_views_util.h" 8 #include "chrome/browser/ui/views/payments/payment_request_views_util.h"
9 #include "components/strings/grit/components_strings.h" 9 #include "components/strings/grit/components_strings.h"
10 #include "ui/base/l10n/l10n_util.h" 10 #include "ui/base/l10n/l10n_util.h"
11 #include "ui/views/background.h" 11 #include "ui/views/background.h"
12 #include "ui/views/controls/button/md_text_button.h" 12 #include "ui/views/controls/button/md_text_button.h"
13 #include "ui/views/layout/box_layout.h" 13 #include "ui/views/layout/box_layout.h"
14 #include "ui/views/layout/grid_layout.h" 14 #include "ui/views/layout/grid_layout.h"
15 15
16 namespace payments { 16 namespace payments {
17 17
18 PaymentRequestSheetController::PaymentRequestSheetController( 18 PaymentRequestSheetController::PaymentRequestSheetController(
19 PaymentRequest* request, PaymentRequestDialogView* dialog) 19 PaymentRequest* request, PaymentRequestDialogView* dialog)
20 : request_(request), dialog_(dialog) { 20 : request_(request), dialog_(dialog) {
21 } 21 }
22 22
23 std::unique_ptr<views::Button> 23 std::unique_ptr<views::Button>
24 PaymentRequestSheetController::CreatePrimaryButton() { 24 PaymentRequestSheetController::CreatePrimaryButton() {
25 return nullptr; 25 return nullptr;
26 } 26 }
27 27
28 std::unique_ptr<views::View> PaymentRequestSheetController::CreateExtraView() { 28 std::unique_ptr<views::View>
29 PaymentRequestSheetController::CreateExtraFooterView() {
29 return nullptr; 30 return nullptr;
30 } 31 }
31 32
32 void PaymentRequestSheetController::ButtonPressed( 33 void PaymentRequestSheetController::ButtonPressed(
33 views::Button* sender, const ui::Event& event) { 34 views::Button* sender, const ui::Event& event) {
34 switch (static_cast<PaymentRequestCommonTags>(sender->tag())) { 35 switch (static_cast<PaymentRequestCommonTags>(sender->tag())) {
35 case PaymentRequestCommonTags::CLOSE_BUTTON_TAG: 36 case PaymentRequestCommonTags::CLOSE_BUTTON_TAG:
36 dialog()->CloseDialog(); 37 dialog()->CloseDialog();
37 break; 38 break;
38 case PaymentRequestCommonTags::BACK_BUTTON_TAG: 39 case PaymentRequestCommonTags::BACK_BUTTON_TAG:
(...skipping 44 matching lines...) Expand 10 before | Expand all | Expand 10 after
83 views::GridLayout* layout = new views::GridLayout(container.get()); 84 views::GridLayout* layout = new views::GridLayout(container.get());
84 container->SetLayoutManager(layout); 85 container->SetLayoutManager(layout);
85 86
86 views::ColumnSet* columns = layout->AddColumnSet(0); 87 views::ColumnSet* columns = layout->AddColumnSet(0);
87 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER, 88 columns->AddColumn(views::GridLayout::LEADING, views::GridLayout::CENTER,
88 0, views::GridLayout::USE_PREF, 0, 0); 89 0, views::GridLayout::USE_PREF, 0, 0);
89 columns->AddPaddingColumn(1, 0); 90 columns->AddPaddingColumn(1, 0);
90 columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER, 91 columns->AddColumn(views::GridLayout::TRAILING, views::GridLayout::CENTER,
91 0, views::GridLayout::USE_PREF, 0, 0); 92 0, views::GridLayout::USE_PREF, 0, 0);
92 93
94 // The horizontal distance between the right/left edges of the dialog and the
95 // elements.
96 constexpr int kFooterHorizontalInset = 16;
97 // The vertical distance between footer elements and the top/bottom border
98 // (the bottom border is the edge of the dialog).
99 constexpr int kFooterVerticalInset = 16;
100 layout->SetInsets(kFooterVerticalInset, kFooterHorizontalInset,
101 kFooterVerticalInset, kFooterHorizontalInset);
93 layout->StartRow(0, 0); 102 layout->StartRow(0, 0);
94 std::unique_ptr<views::View> extra_view = CreateExtraView(); 103 std::unique_ptr<views::View> extra_view = CreateExtraFooterView();
95 if (extra_view) 104 if (extra_view)
96 layout->AddView(extra_view.release()); 105 layout->AddView(extra_view.release());
97 else 106 else
98 layout->SkipColumns(1); 107 layout->SkipColumns(1);
99 108
100 std::unique_ptr<views::View> trailing_buttons_container = 109 std::unique_ptr<views::View> trailing_buttons_container =
101 base::MakeUnique<views::View>(); 110 base::MakeUnique<views::View>();
102 111
103 trailing_buttons_container->SetLayoutManager(new views::BoxLayout( 112 trailing_buttons_container->SetLayoutManager(new views::BoxLayout(
104 views::BoxLayout::kHorizontal, kPaymentRequestRowHorizontalInsets, 113 views::BoxLayout::kHorizontal, kPaymentRequestRowHorizontalInsets,
105 kPaymentRequestRowVerticalInsets, kPaymentRequestButtonSpacing)); 114 kPaymentRequestRowVerticalInsets, kPaymentRequestButtonSpacing));
106 115
107 std::unique_ptr<views::Button> primary_button = CreatePrimaryButton(); 116 std::unique_ptr<views::Button> primary_button = CreatePrimaryButton();
108 if (primary_button) 117 if (primary_button)
109 trailing_buttons_container->AddChildView(primary_button.release()); 118 trailing_buttons_container->AddChildView(primary_button.release());
110 119
111 views::LabelButton* button = views::MdTextButton::CreateSecondaryUiButton( 120 views::LabelButton* button = views::MdTextButton::CreateSecondaryUiButton(
112 this, l10n_util::GetStringUTF16(IDS_CANCEL)); 121 this, l10n_util::GetStringUTF16(IDS_CANCEL));
113 button->set_tag(static_cast<int>(PaymentRequestCommonTags::CLOSE_BUTTON_TAG)); 122 button->set_tag(static_cast<int>(PaymentRequestCommonTags::CLOSE_BUTTON_TAG));
114 trailing_buttons_container->AddChildView(button); 123 trailing_buttons_container->AddChildView(button);
115 124
116 layout->AddView(trailing_buttons_container.release()); 125 layout->AddView(trailing_buttons_container.release());
117 126
118 return container; 127 return container;
119 } 128 }
120 129
121 std::unique_ptr<views::View>
122 PaymentRequestSheetController::CreateLeadingFooterView() {
123 return base::MakeUnique<views::View>();
124 }
125
126 } // namespace payments 130 } // namespace payments
OLDNEW
« no previous file with comments | « chrome/browser/ui/views/payments/payment_request_sheet_controller.h ('k') | components/payments/payment_request.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698