Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF

BUG=crashpad:100, crashpad:157, crashpad:159, crashpad:161, crashpad:162
Review-Url: https://codereview.chromium.org/2710663006
Cr-Original-Commit-Position: refs/heads/master@{#452387}
Committed: https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763bcb1ee52fd227
Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452510}
Committed: https://chromium.googlesource.com/chromium/src/+/d0b0e164df66904125ecdcf3473212a1d97a11ce

[Mark Mentovai, 2017-02-22 19:08:22]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[Mark Mentovai, 2017-02-22 19:08:31]

mark@chromium.org changed reviewers:
+ scottmg@chromium.org

[commit-bot: I haz the power, 2017-02-22 19:09:17]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-02-22 19:10:07]

mark@chromium.org changed reviewers:
+ isherman@chromium.org

[Mark Mentovai, 2017-02-22 19:10:08]

Scott for the Crashpad update and gn files, Ilya for histograms.xml.

[scottmg, 2017-02-22 19:33:45]

lgtm

[Ilya Sherman, 2017-02-22 20:16:18]

Metrics LGTM % comments

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.cc (right):

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.cc:105:
static_cast<int32_t>(LifetimeMilestone::kMaxValue));
Hmm, are the static_casts needed?  In theory we have some template magic that
tries to make them unnecessary... bummer if it isn't working.

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.h (right):

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.h:133: //! \brief An important
event in a handler process’ lifetime.
Please document that this is used to back an UMA histogram, and should therefore
be treated as append-only.

[Mark Mentovai, 2017-02-22 20:27:48]

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.cc (right):

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.cc:105:
static_cast<int32_t>(LifetimeMilestone::kMaxValue));
On 2017/02/22 20:16:18, Ilya Sherman wrote:
> Hmm, are the static_casts needed?  In theory we have some template magic that
> tries to make them unnecessary... bummer if it isn't working.

It's because we use enum class in Crashpad pretty regularly for type safety.

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.h (right):

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.h:133: //! \brief An important
event in a handler process’ lifetime.
On 2017/02/22 20:16:18, Ilya Sherman wrote:
> Please document that this is used to back an UMA histogram, and should
therefore
> be treated as append-only.

Everything in this file is for UMA support. Do you want to see that note on each
enum as boilerplate?

[commit-bot: I haz the power, 2017-02-22 20:44:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-02-22 20:44:45]

Dry run: Try jobs failed on following builders:
  win_clang on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_clang/builds/...)

[Ilya Sherman, 2017-02-22 22:53:01]

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.cc (right):

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.cc:105:
static_cast<int32_t>(LifetimeMilestone::kMaxValue));
On 2017/02/22 20:27:47, Mark Mentovai wrote:
> On 2017/02/22 20:16:18, Ilya Sherman wrote:
> > Hmm, are the static_casts needed?  In theory we have some template magic
that
> > tries to make them unnecessary... bummer if it isn't working.
> 
> It's because we use enum class in Crashpad pretty regularly for type safety.

Yes, I understand that.  The intent of the template magic was to make it
typesafe to use enum classes with histogram macros.  Oh well.

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
File third_party/crashpad/crashpad/util/misc/metrics.h (right):

https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
third_party/crashpad/crashpad/util/misc/metrics.h:133: //! \brief An important
event in a handler process’ lifetime.
On 2017/02/22 20:27:47, Mark Mentovai wrote:
> On 2017/02/22 20:16:18, Ilya Sherman wrote:
> > Please document that this is used to back an UMA histogram, and should
> therefore
> > be treated as append-only.
> 
> Everything in this file is for UMA support. Do you want to see that note on
each
> enum as boilerplate?

I'd generally lean toward yes, because not all developers will otherwise realize
that this constraint is important, even if they realize that the file is related
to metrics.  But, I defer to your judgement on this point.

[Mark Mentovai, 2017-02-22 23:11:11]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[Mark Mentovai, 2017-02-22 23:11:56]

On 2017/02/22 22:53:01, Ilya Sherman wrote:
>
https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
> File third_party/crashpad/crashpad/util/misc/metrics.cc (right):
> 
>
https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
> third_party/crashpad/crashpad/util/misc/metrics.cc:105:
> static_cast<int32_t>(LifetimeMilestone::kMaxValue));
> On 2017/02/22 20:27:47, Mark Mentovai wrote:
> > On 2017/02/22 20:16:18, Ilya Sherman wrote:
> > > Hmm, are the static_casts needed?  In theory we have some template magic
> that
> > > tries to make them unnecessary... bummer if it isn't working.
> > 
> > It's because we use enum class in Crashpad pretty regularly for type safety.
> 
> Yes, I understand that.  The intent of the template magic was to make it
> typesafe to use enum classes with histogram macros.  Oh well.
> 
>
https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
> File third_party/crashpad/crashpad/util/misc/metrics.h (right):
> 
>
https://codereview.chromium.org/2710663006/diff/1/third_party/crashpad/crashp...
> third_party/crashpad/crashpad/util/misc/metrics.h:133: //! \brief An important
> event in a handler process’ lifetime.
> On 2017/02/22 20:27:47, Mark Mentovai wrote:
> > On 2017/02/22 20:16:18, Ilya Sherman wrote:
> > > Please document that this is used to back an UMA histogram, and should
> > therefore
> > > be treated as append-only.
> > 
> > Everything in this file is for UMA support. Do you want to see that note on
> each
> > enum as boilerplate?
> 
> I'd generally lean toward yes, because not all developers will otherwise
realize
> that this constraint is important, even if they realize that the file is
related
> to metrics.  But, I defer to your judgement on this point.

Gotcha. I updated metrics.h and metrics.cc to eliminate the casts and to add the
comments you requested. I’m feeding it to the try server now. If any of them
show that the casts are still necessary, I’ll put them back before landing.
Thanks for the review.

[commit-bot: I haz the power, 2017-02-22 23:12:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ilya Sherman, 2017-02-22 23:18:44]

On 2017/02/22 23:11:56, Mark Mentovai wrote:
> Gotcha. I updated metrics.h and metrics.cc to eliminate the casts and to add
the
> comments you requested. I’m feeding it to the try server now. If any of them
> show that the casts are still necessary, I’ll put them back before landing.
> Thanks for the review.

Thanks!  FWIW, I couldn't find the template magic that I was thinking of.  I
wonder if the CL that I'm remembering never landed?  Having trouble finding a
concrete reference in my email search history now, but Gmail search has never
been the best.  I guess we'll see what the try servers say...

[Mark Mentovai, 2017-02-23 00:14:08]

Description was changed from

==========
Update Crashpad to f34ed66b93a0b42a58314af2784eee879a297ed5

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

to

==========
Update Crashpad to c1af20f1aa8a8f34b88c59c26ec8fece8504d3e9

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

[Mark Mentovai, 2017-02-23 00:28:10]

The CQ bit was checked by mark@chromium.org

[Mark Mentovai, 2017-02-23 00:28:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2710663006/#ps80001
(title: "Update to Crashpad c1af20f1aa8a")

[commit-bot: I haz the power, 2017-02-23 00:28:52]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-02-23 01:10:14]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:10:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-02-23 01:45:55]

Description was changed from

==========
Update Crashpad to c1af20f1aa8a8f34b88c59c26ec8fece8504d3e9

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

to

==========
Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

[Mark Mentovai, 2017-02-23 01:47:39]

The CQ bit was checked by mark@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-02-23 01:48:08]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Mark Mentovai, 2017-02-23 01:49:53]

Ilya Sherman wrote:
> On 2017/02/22 23:11:56, Mark Mentovai wrote:
> > Gotcha. I updated metrics.h and metrics.cc to eliminate the casts and to add
> the
> > comments you requested. I’m feeding it to the try server now. If any of them
> > show that the casts are still necessary, I’ll put them back before landing.
> > Thanks for the review.
> 
> Thanks!  FWIW, I couldn't find the template magic that I was thinking of.  I
> wonder if the CL that I'm remembering never landed?  Having trouble finding a
> concrete reference in my email search history now, but Gmail search has never
> been the best.  I guess we'll see what the try servers say...

The static_cast<> removal definitely didn’t work. If the template magic ever
does land, let me know. I’d love to get rid of the casts.

[Mark Mentovai, 2017-02-23 01:50:02]

The CQ bit was unchecked by mark@chromium.org

[Mark Mentovai, 2017-02-23 01:50:08]

The CQ bit was checked by mark@chromium.org

[Mark Mentovai, 2017-02-23 01:50:09]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2710663006/#ps120001
(title: "Update to Crashpad 6da9708e7cc9")

[commit-bot: I haz the power, 2017-02-23 01:50:26]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-02-23 04:08:43]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1487814608161920,
"parent_rev": "316af82da4f99b3dc48d84d8153945d2d0b395be", "commit_rev":
"c4d7eaed0fcac839f1fd4f2a763bcb1ee52fd227"}

[commit-bot: I haz the power, 2017-02-23 04:09:59]

Description was changed from

==========
Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162
==========

to

==========
Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

[commit-bot: I haz the power, 2017-02-23 04:10:00]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...

[tzik, 2017-02-23 05:37:39]

On 2017/02/23 04:10:00, commit-bot: I haz the power wrote:
> Committed patchset #7 (id:120001) as
>
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...

This CL seem to cause a mac compile failure.
Let me revert this as https://codereview.chromium.org/2705373005/.

[tzik, 2017-02-23 05:37:52]

Description was changed from

==========
Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

to

==========
Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

[Mark Mentovai, 2017-02-23 14:57:17]

Description was changed from

==========
Update Crashpad to 6da9708e7cc93e2e1772439d51646e47583cb225

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

to

==========
Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

[Mark Mentovai, 2017-02-23 15:10:44]

The CQ bit was checked by mark@chromium.org

[Mark Mentovai, 2017-02-23 15:10:45]

The patchset sent to the CQ was uploaded after l-g-t-m from
isherman@chromium.org, scottmg@chromium.org
Link to the patchset: https://codereview.chromium.org/2710663006/#ps140001
(title: "Update Crashpad to 4a2043ea65e2")

[commit-bot: I haz the power, 2017-02-23 15:10:58]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[scottmg, 2017-02-23 15:53:51]

Description was changed from

==========
Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

to

==========
Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

[scottmg, 2017-02-23 15:54:03]

(updated subject)

[Mark Mentovai, 2017-02-23 15:55:45]

On 2017/02/23 15:54:03, scottmg wrote:
> (updated subject)

[Mark Mentovai, 2017-02-23 15:56:24]

scottmg wrote:
> (updated subject)

Thanks, I didn’t do that because I thought it would start a new e-mail thread.
Guess that’s been fixed.

[commit-bot: I haz the power, 2017-02-23 16:11:09]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1487862644524570,
"parent_rev": "ecd5d94adb8e604304ed27b7c1ffc2c8225cfa28", "commit_rev":
"d0b0e164df66904125ecdcf3473212a1d97a11ce"}

[commit-bot: I haz the power, 2017-02-23 16:11:47]

Description was changed from

==========
Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
==========

to

==========
Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7

1f82c6cc8a35 Ensure Content-Length does not appear with Transfer-
             Encoding
c1b305244aba Update mig.py to take an explicit sdk argument
d98a4de718d9 win: support native x86 CONTEXT structures with x87 but no
             SSE context
0c322ecc3f71 Use zlib to gzip-compress uploads
546e64cd0b1b Centrally define CPUContextX86::Fsave and fsave↔︎fxsave
             conversions
4c6f6e52e2d7 Remove vestigial support for in-Chromium GYP build
f34ed66b93a0 metrics: Record handler lifetime milestone events
c1af20f1aa8a metrics: Consistently comment about enums used for metrics
9c8407123796 Fix warning when building with clang on Windows
6da9708e7cc9 doc: Fix Doxygen errors
4a2043ea65e2 Fix Chromium build with DPLOG_IF

BUG=crashpad:100,crashpad:157,crashpad:159,crashpad:161,crashpad:162

Review-Url: https://codereview.chromium.org/2710663006
Cr-Original-Commit-Position: refs/heads/master@{#452387}
Committed:
https://chromium.googlesource.com/chromium/src/+/c4d7eaed0fcac839f1fd4f2a763b...
Review-Url: https://codereview.chromium.org/2710663006
Cr-Commit-Position: refs/heads/master@{#452510}
Committed:
https://chromium.googlesource.com/chromium/src/+/d0b0e164df66904125ecdcf34732...
==========

[commit-bot: I haz the power, 2017-02-23 16:11:49]

Committed patchset #8 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/d0b0e164df66904125ecdcf34732...