Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1174)

Unified Diff: third_party/crashpad/crashpad/test/hex_string.cc

Issue 2710663006: Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7 (Closed)
Patch Set: Update Crashpad to 4a2043ea65e2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/crashpad/crashpad/test/hex_string.cc
diff --git a/third_party/crashpad/crashpad/util/win/scoped_handle.cc b/third_party/crashpad/crashpad/test/hex_string.cc
similarity index 54%
copy from third_party/crashpad/crashpad/util/win/scoped_handle.cc
copy to third_party/crashpad/crashpad/test/hex_string.cc
index 5eb440e045da703f76162fe8bc5e84a54b23e77a..bb9b5f3a89eae727a5a9df9f616a2adbebc78f6b 100644
--- a/third_party/crashpad/crashpad/util/win/scoped_handle.cc
+++ b/third_party/crashpad/crashpad/test/hex_string.cc
@@ -1,4 +1,4 @@
-// Copyright 2014 The Crashpad Authors. All rights reserved.
+// Copyright 2017 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -12,21 +12,24 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "util/win/scoped_handle.h"
+#include "test/hex_string.h"
-#include "base/logging.h"
-#include "util/file/file_io.h"
+#include "base/strings/stringprintf.h"
namespace crashpad {
-namespace internal {
+namespace test {
-void ScopedFileHANDLECloseTraits::Free(HANDLE handle) {
- CheckedCloseFile(handle);
-}
+std::string BytesToHexString(const void* bytes, size_t length) {
+ const unsigned char* bytes_c = reinterpret_cast<const unsigned char*>(bytes);
+
+ std::string hex_string;
+ hex_string.reserve(length * 2);
+ for (size_t index = 0; index < length; ++index) {
+ hex_string.append(base::StringPrintf("%02x", bytes_c[index]));
+ }
-void ScopedKernelHANDLECloseTraits::Free(HANDLE handle) {
- PCHECK(CloseHandle(handle));
+ return hex_string;
}
-} // namespace internal
+} // namespace test
} // namespace crashpad
« no previous file with comments | « third_party/crashpad/crashpad/test/hex_string.h ('k') | third_party/crashpad/crashpad/test/hex_string_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698