Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(456)

Unified Diff: third_party/crashpad/crashpad/test/hex_string_test.cc

Issue 2710663006: Update Crashpad to 4a2043ea65e2641ef1a921801c0aaa15ada02fc7 (Closed)
Patch Set: Update Crashpad to 4a2043ea65e2 Created 3 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/crashpad/crashpad/test/hex_string.cc ('k') | third_party/crashpad/crashpad/test/test.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/crashpad/crashpad/test/hex_string_test.cc
diff --git a/third_party/crashpad/crashpad/util/win/scoped_handle.cc b/third_party/crashpad/crashpad/test/hex_string_test.cc
similarity index 57%
copy from third_party/crashpad/crashpad/util/win/scoped_handle.cc
copy to third_party/crashpad/crashpad/test/hex_string_test.cc
index 5eb440e045da703f76162fe8bc5e84a54b23e77a..62b45c1260ed1d17223b312c4be51ab10cf791f1 100644
--- a/third_party/crashpad/crashpad/util/win/scoped_handle.cc
+++ b/third_party/crashpad/crashpad/test/hex_string_test.cc
@@ -1,4 +1,4 @@
-// Copyright 2014 The Crashpad Authors. All rights reserved.
+// Copyright 2017 The Crashpad Authors. All rights reserved.
//
// Licensed under the Apache License, Version 2.0 (the "License");
// you may not use this file except in compliance with the License.
@@ -12,21 +12,23 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-#include "util/win/scoped_handle.h"
+#include "test/hex_string.h"
-#include "base/logging.h"
-#include "util/file/file_io.h"
+#include "base/macros.h"
+#include "gtest/gtest.h"
namespace crashpad {
-namespace internal {
+namespace test {
+namespace {
-void ScopedFileHANDLECloseTraits::Free(HANDLE handle) {
- CheckedCloseFile(handle);
-}
+TEST(HexString, HexString) {
+ EXPECT_EQ("", BytesToHexString(nullptr, 0));
-void ScopedKernelHANDLECloseTraits::Free(HANDLE handle) {
- PCHECK(CloseHandle(handle));
+ const char kBytes[] = "Abc123xyz \x0a\x7f\xf0\x9f\x92\xa9_";
+ EXPECT_EQ("41626331323378797a200a7ff09f92a95f00",
+ BytesToHexString(kBytes, arraysize(kBytes)));
}
-} // namespace internal
+} // namespace
+} // namespace test
} // namespace crashpad
« no previous file with comments | « third_party/crashpad/crashpad/test/hex_string.cc ('k') | third_party/crashpad/crashpad/test/test.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698