Remove duplicated user_prefs::TestingPrefServiceSyncable

Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900
R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org, pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

Committed: https://crrev.com/b2cf8f80ac8a98bff39300e3b1465012eaa5abdf
Cr-Commit-Position: refs/heads/master@{#437790}

[Alexander Yashkin, 2016-12-09 14:46:30]

The CQ bit was checked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2016-12-09 14:46:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:46:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:46:44]

No L-G-T-M from a valid reviewer yet. 
CQ run can only be started by full committers or once the patch has
received an L-G-T-M from a full committer.
Even if an L-G-T-M may have been provided, it was from a non-committer,
_not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.

[vabr (Chromium), 2016-12-09 14:51:23]

Could you please file a bug for this and reference it in the CL description?

Other than that, the change in //components/password_manager LGTM.

I'll start the CQ dry-run for you.

Cheers,
Vaclav

[vabr (Chromium), 2016-12-09 14:51:34]

The CQ bit was checked by vabr@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-12-09 14:51:54]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-09 14:55:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-09 14:55:50]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[gab, 2016-12-09 15:07:36]

//components/prefs_registry lgtm as well as any required DEPS addition for
//components/sync_preferences.

PS: it's okay to TBR other OWNERS for side-effects with changes like these.

Thanks!

[Alexander Yashkin, 2016-12-10 05:34:21]

Description was changed from

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org
==========

to

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org
==========

[Alexander Yashkin, 2016-12-10 06:09:33]

The CQ bit was checked by a-v-y@yandex-team.ru

[Alexander Yashkin, 2016-12-10 06:09:34]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2562733003/#ps20001
(title: "More includes changed to
sync_preferences/testing_pref_service_syncable.h")

[commit-bot: I haz the power, 2016-12-10 06:09:43]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 06:13:17]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 06:13:18]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[Alexander Yashkin, 2016-12-10 11:35:57]

Description was changed from

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org
==========

to

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org,
pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org,
blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org
==========

[Alexander Yashkin, 2016-12-10 11:36:04]

The CQ bit was checked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2016-12-10 11:36:13]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 11:39:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 11:39:43]

Try jobs failed on following builders:
  android_clang_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/android_clan...)

[Alexander Yashkin, 2016-12-10 19:32:16]

The CQ bit was checked by a-v-y@yandex-team.ru

[Alexander Yashkin, 2016-12-10 19:32:17]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2562733003/#ps40001
(title: "deps fixed in BUILD.gn after removal of pref_registry:test_support")

[commit-bot: I haz the power, 2016-12-10 19:32:31]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 19:41:43]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 19:41:45]

Try jobs failed on following builders:
  ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device-xcode-...)

[Alexander Yashkin, 2016-12-10 20:14:57]

The CQ bit was checked by a-v-y@yandex-team.ru

[Alexander Yashkin, 2016-12-10 20:14:58]

The patchset sent to the CQ was uploaded after l-g-t-m from vabr@chromium.org,
gab@chromium.org
Link to the patchset: https://codereview.chromium.org/2562733003/#ps60001
(title: "Fixed usage from .mm files")

[commit-bot: I haz the power, 2016-12-10 20:15:11]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-10 21:51:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-12-10 21:51:19]

Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Alexander Yashkin, 2016-12-11 07:13:43]

The CQ bit was checked by a-v-y@yandex-team.ru

[commit-bot: I haz the power, 2016-12-11 07:13:48]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-12-11 17:35:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1481440423120450,
"parent_rev": "b6a17a68b246f71cb43d062898a54458d0b25fff", "commit_rev":
"bcbbe472b7945f2a7adc7de662415644fd11fe3b"}

[commit-bot: I haz the power, 2016-12-11 17:36:20]

Description was changed from

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org,
pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org,
blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org
==========

to

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org,
pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org,
blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

Review-Url: https://codereview.chromium.org/2562733003
==========

[commit-bot: I haz the power, 2016-12-11 17:36:21]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-12-12 15:09:41]

Description was changed from

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org,
pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org,
blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

Review-Url: https://codereview.chromium.org/2562733003
==========

to

==========
Remove duplicated user_prefs::TestingPrefServiceSyncable

In https://codereview.chromium.org/2479113002/ it was discovered that
current codebase has two duplicate TestingPrefServiceSyncable classes.
One in component/sync_preferences and another in
components/pref_registry. The decision from discussion is to delete the
one in components/pref_registry.

BUG=672900

R=gab@chromium.org, vasilii@chromium.org, hashimoto@chromium.org,
pkasting@chromium.org, rdevlin.cronin@chromium.org, ben@chromium.org,
blundell@chromium.org

TBR=rdevlin.cronin@chromium.org, ben@chromium.org, blundell@chromium.org

Committed: https://crrev.com/b2cf8f80ac8a98bff39300e3b1465012eaa5abdf
Cr-Commit-Position: refs/heads/master@{#437790}
==========

[commit-bot: I haz the power, 2016-12-12 15:09:43]

Patchset 4 (id:??) landed as
https://crrev.com/b2cf8f80ac8a98bff39300e3b1465012eaa5abdf
Cr-Commit-Position: refs/heads/master@{#437790}