Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(30)

Side by Side Diff: components/translate/core/browser/translate_ranker_unittest.cc

Issue 2562733003: Remove duplicated user_prefs::TestingPrefServiceSyncable (Closed)
Patch Set: Fixed usage from .mm files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2016 The Chromium Authors. All rights reserved. 1 // Copyright 2016 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_ranker.h" 5 #include "components/translate/core/browser/translate_ranker.h"
6 6
7 #include <initializer_list> 7 #include <initializer_list>
8 #include <memory> 8 #include <memory>
9 9
10 #include "base/feature_list.h" 10 #include "base/feature_list.h"
11 #include "base/strings/stringprintf.h" 11 #include "base/strings/stringprintf.h"
12 #include "base/test/scoped_feature_list.h" 12 #include "base/test/scoped_feature_list.h"
13 #include "components/metrics/proto/translate_event.pb.h" 13 #include "components/metrics/proto/translate_event.pb.h"
14 #include "components/pref_registry/testing_pref_service_syncable.h"
15 #include "components/prefs/scoped_user_pref_update.h" 14 #include "components/prefs/scoped_user_pref_update.h"
15 #include "components/sync_preferences/testing_pref_service_syncable.h"
16 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h" 16 #include "components/translate/core/browser/proto/translate_ranker_model.pb.h"
17 #include "components/translate/core/browser/translate_download_manager.h" 17 #include "components/translate/core/browser/translate_download_manager.h"
18 #include "components/translate/core/browser/translate_prefs.h" 18 #include "components/translate/core/browser/translate_prefs.h"
19 #include "testing/gtest/include/gtest/gtest.h" 19 #include "testing/gtest/include/gtest/gtest.h"
20 20
21 namespace translate { 21 namespace translate {
22 22
23 class TranslateRankerTest : public ::testing::Test { 23 class TranslateRankerTest : public ::testing::Test {
24 protected: 24 protected:
25 TranslateRankerTest() {} 25 TranslateRankerTest() {}
26 26
27 void SetUp() override { 27 void SetUp() override {
28 locale_ = TranslateDownloadManager::GetInstance()->application_locale(); 28 locale_ = TranslateDownloadManager::GetInstance()->application_locale();
29 TranslateDownloadManager::GetInstance()->set_application_locale("zh-CN"); 29 TranslateDownloadManager::GetInstance()->set_application_locale("zh-CN");
30 30
31 // Setup a 50/50 accepted/denied count for "english" when initialize the 31 // Setup a 50/50 accepted/denied count for "english" when initialize the
32 // prefs and translate prefs. 32 // prefs and translate prefs.
33 base::DictionaryValue lang_count; 33 base::DictionaryValue lang_count;
34 lang_count.SetInteger("en", 50); 34 lang_count.SetInteger("en", 50);
35 prefs_.reset(new user_prefs::TestingPrefServiceSyncable()); 35 prefs_.reset(new sync_preferences::TestingPrefServiceSyncable());
36 TranslatePrefs::RegisterProfilePrefs(prefs_->registry()); 36 TranslatePrefs::RegisterProfilePrefs(prefs_->registry());
37 prefs_->Set(TranslatePrefs::kPrefTranslateAcceptedCount, lang_count); 37 prefs_->Set(TranslatePrefs::kPrefTranslateAcceptedCount, lang_count);
38 prefs_->Set(TranslatePrefs::kPrefTranslateDeniedCount, lang_count); 38 prefs_->Set(TranslatePrefs::kPrefTranslateDeniedCount, lang_count);
39 translate_prefs_.reset(new TranslatePrefs( 39 translate_prefs_.reset(new TranslatePrefs(
40 prefs_.get(), "intl.accept_languages", kPreferredLanguagePrefs)); 40 prefs_.get(), "intl.accept_languages", kPreferredLanguagePrefs));
41 translate_prefs_->SetCountry("us"); 41 translate_prefs_->SetCountry("us");
42 } 42 }
43 43
44 void TearDown() override { 44 void TearDown() override {
45 TranslateDownloadManager::GetInstance()->set_application_locale(locale_); 45 TranslateDownloadManager::GetInstance()->set_application_locale(locale_);
(...skipping 45 matching lines...) Expand 10 before | Expand all | Expand 10 after
91 translate_event.set_source_language(src_lang); 91 translate_event.set_source_language(src_lang);
92 translate_event.set_target_language(dst_lang); 92 translate_event.set_target_language(dst_lang);
93 translate_event.set_accept_count(accept_count); 93 translate_event.set_accept_count(accept_count);
94 translate_event.set_decline_count(decline_count); 94 translate_event.set_decline_count(decline_count);
95 translate_event.set_ignore_count(ignore_count); 95 translate_event.set_ignore_count(ignore_count);
96 return translate_event; 96 return translate_event;
97 } 97 }
98 98
99 static const char* const kPreferredLanguagePrefs; 99 static const char* const kPreferredLanguagePrefs;
100 100
101 std::unique_ptr<user_prefs::TestingPrefServiceSyncable> prefs_; 101 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_;
102 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; 102 std::unique_ptr<translate::TranslatePrefs> translate_prefs_;
103 103
104 private: 104 private:
105 // Manages the enabling/disabling of features within the scope of a test. 105 // Manages the enabling/disabling of features within the scope of a test.
106 base::test::ScopedFeatureList scoped_feature_list_; 106 base::test::ScopedFeatureList scoped_feature_list_;
107 107
108 // Cache and reset the application locale for each test. 108 // Cache and reset the application locale for each test.
109 std::string locale_; 109 std::string locale_;
110 110
111 DISALLOW_COPY_AND_ASSIGN(TranslateRankerTest); 111 DISALLOW_COPY_AND_ASSIGN(TranslateRankerTest);
(...skipping 110 matching lines...) Expand 10 before | Expand all | Expand 10 after
222 ranker->RecordTranslateEvent(event_1); 222 ranker->RecordTranslateEvent(event_1);
223 ranker->RecordTranslateEvent(event_2); 223 ranker->RecordTranslateEvent(event_2);
224 ranker->RecordTranslateEvent(event_3); 224 ranker->RecordTranslateEvent(event_3);
225 225
226 // Logging is disabled, so no events should be cached. 226 // Logging is disabled, so no events should be cached.
227 ranker->FlushTranslateEvents(&flushed_events); 227 ranker->FlushTranslateEvents(&flushed_events);
228 EXPECT_EQ(0U, flushed_events.size()); 228 EXPECT_EQ(0U, flushed_events.size());
229 } 229 }
230 230
231 } // namespace translate 231 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698