Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Side by Side Diff: components/translate/core/browser/translate_prefs_unittest.cc

Issue 2562733003: Remove duplicated user_prefs::TestingPrefServiceSyncable (Closed)
Patch Set: Fixed usage from .mm files Created 4 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "components/translate/core/browser/translate_prefs.h" 5 #include "components/translate/core/browser/translate_prefs.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 #include <string> 8 #include <string>
9 #include <utility> 9 #include <utility>
10 #include <vector> 10 #include <vector>
11 11
12 #include "base/json/json_reader.h" 12 #include "base/json/json_reader.h"
13 #include "base/test/scoped_feature_list.h" 13 #include "base/test/scoped_feature_list.h"
14 #include "base/values.h" 14 #include "base/values.h"
15 #include "build/build_config.h" 15 #include "build/build_config.h"
16 #include "components/pref_registry/testing_pref_service_syncable.h"
17 #include "components/prefs/scoped_user_pref_update.h" 16 #include "components/prefs/scoped_user_pref_update.h"
17 #include "components/sync_preferences/testing_pref_service_syncable.h"
18 #include "components/translate/core/browser/translate_download_manager.h" 18 #include "components/translate/core/browser/translate_download_manager.h"
19 #include "components/translate/core/browser/translate_prefs.h" 19 #include "components/translate/core/browser/translate_prefs.h"
20 #include "testing/gtest/include/gtest/gtest.h" 20 #include "testing/gtest/include/gtest/gtest.h"
21 21
22 namespace { 22 namespace {
23 23
24 const char kTestLanguage[] = "en"; 24 const char kTestLanguage[] = "en";
25 25
26 } // namespace 26 } // namespace
27 27
28 namespace translate { 28 namespace translate {
29 29
30 class TranslatePrefTest : public testing::Test { 30 class TranslatePrefTest : public testing::Test {
31 protected: 31 protected:
32 TranslatePrefTest() : prefs_(new user_prefs::TestingPrefServiceSyncable()) { 32 TranslatePrefTest()
33 : prefs_(new sync_preferences::TestingPrefServiceSyncable()) {
33 #if defined(OS_CHROMEOS) 34 #if defined(OS_CHROMEOS)
34 const char* preferred_languages_prefs = 35 const char* preferred_languages_prefs =
35 "settings.language.preferred_languages"; 36 "settings.language.preferred_languages";
36 #else 37 #else
37 const char* preferred_languages_prefs = NULL; 38 const char* preferred_languages_prefs = NULL;
38 #endif 39 #endif
39 translate_prefs_.reset(new translate::TranslatePrefs( 40 translate_prefs_.reset(new translate::TranslatePrefs(
40 prefs_.get(), "intl.accept_languages", preferred_languages_prefs)); 41 prefs_.get(), "intl.accept_languages", preferred_languages_prefs));
41 TranslatePrefs::RegisterProfilePrefs(prefs_->registry()); 42 TranslatePrefs::RegisterProfilePrefs(prefs_->registry());
42 now_ = base::Time::Now(); 43 now_ = base::Time::Now();
43 two_days_ago_ = now_ - base::TimeDelta::FromDays(2); 44 two_days_ago_ = now_ - base::TimeDelta::FromDays(2);
44 } 45 }
45 46
46 void SetLastDeniedTime(const std::string& language, base::Time time) { 47 void SetLastDeniedTime(const std::string& language, base::Time time) {
47 DenialTimeUpdate update(prefs_.get(), language, 2); 48 DenialTimeUpdate update(prefs_.get(), language, 2);
48 update.AddDenialTime(time); 49 update.AddDenialTime(time);
49 } 50 }
50 51
51 base::Time GetLastDeniedTime(const std::string& language) { 52 base::Time GetLastDeniedTime(const std::string& language) {
52 DenialTimeUpdate update(prefs_.get(), language, 2); 53 DenialTimeUpdate update(prefs_.get(), language, 2);
53 return update.GetOldestDenialTime(); 54 return update.GetOldestDenialTime();
54 } 55 }
55 56
56 std::unique_ptr<user_prefs::TestingPrefServiceSyncable> prefs_; 57 std::unique_ptr<sync_preferences::TestingPrefServiceSyncable> prefs_;
57 std::unique_ptr<translate::TranslatePrefs> translate_prefs_; 58 std::unique_ptr<translate::TranslatePrefs> translate_prefs_;
58 59
59 // Shared time constants. 60 // Shared time constants.
60 base::Time now_; 61 base::Time now_;
61 base::Time two_days_ago_; 62 base::Time two_days_ago_;
62 }; 63 };
63 64
64 TEST_F(TranslatePrefTest, IsTooOftenDeniedIn2016Q2UI) { 65 TEST_F(TranslatePrefTest, IsTooOftenDeniedIn2016Q2UI) {
65 base::test::ScopedFeatureList scoped_feature_list; 66 base::test::ScopedFeatureList scoped_feature_list;
66 scoped_feature_list.InitAndEnableFeature(translate::kTranslateUI2016Q2); 67 scoped_feature_list.InitAndEnableFeature(translate::kTranslateUI2016Q2);
(...skipping 263 matching lines...) Expand 10 before | Expand all | Expand 10 after
330 EXPECT_EQ(0.8, translate_prefs_->GetReadingFromUserLanguageProfile(&list)); 331 EXPECT_EQ(0.8, translate_prefs_->GetReadingFromUserLanguageProfile(&list));
331 EXPECT_EQ(2UL, list.size()); 332 EXPECT_EQ(2UL, list.size());
332 EXPECT_EQ("en", list[0].first); // en-US and en-GB will be normalize into en 333 EXPECT_EQ("en", list[0].first); // en-US and en-GB will be normalize into en
333 EXPECT_EQ(0.6, 334 EXPECT_EQ(0.6,
334 list[0].second); // and their probability will add to gether be 0.6 335 list[0].second); // and their probability will add to gether be 0.6
335 EXPECT_EQ("fr", list[1].first); // fr will move down to the 2nd one 336 EXPECT_EQ("fr", list[1].first); // fr will move down to the 2nd one
336 EXPECT_EQ(0.4, list[1].second); 337 EXPECT_EQ(0.4, list[1].second);
337 } 338 }
338 339
339 } // namespace translate 340 } // namespace translate
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698