Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(55)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2447483002: Test win_clang compile only check in core/resources. (Closed)

Created:
4 years, 2 months ago by xingliu
Modified:
4 years, 1 month ago
Reviewers:
CC:
chromium-reviews, jbudorick+watch_chromium.org, anandc+watch-blimp_chromium.org, maniscalco+watch-blimp_chromium.org, sriramsr+watch-blimp_chromium.org, bgoldman+watch-blimp_chromium.org, steimel+watch-blimp_chromium.org, gcasto+watch-blimp_chromium.org, shaktisahu+watch-blimp_chromium.org, nyquist+watch-blimp_chromium.org, perumaal+watch-blimp_chromium.org, marcinjb+watch-blimp_chromium.org, jessicag+watch-blimp_chromium.org, kmarshall+watch-blimp_chromium.org, mikecase+watch_chromium.org, lethalantidote+watch-blimp_chromium.org, agrieve+watch_chromium.org, dtrainor+watch-blimp_chromium.org, scf+watch-blimp_chromium.org, khushalsagar+watch-blimp_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

NOT TO SUBMIT, development purpose only. Test win_clang compile only check in core/resources. BUG=

Patch Set 1 #

Patch Set 2 : Removed app changes. #

Patch Set 3 : removed chrome_repack link. #

Patch Set 4 : Debugging build problem #

Patch Set 5 : filter win platform build #

Unified diffs Side-by-side diffs Delta from patch set Stats (+663 lines, --41 lines) Patch
M blimp/client/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/core/BUILD.gn View 2 chunks +2 lines, -0 lines 0 comments Download
M blimp/client/core/contents/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
A blimp/client/core/resources/BUILD.gn View 1 chunk +203 lines, -0 lines 0 comments Download
A + blimp/client/core/resources/android/java/res/layout/text_input_popup.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/android/java/res/values/arrays.xml View 1 chunk +0 lines, -1 line 0 comments Download
A + blimp/client/core/resources/android/java/res/xml/blimp_preferences.xml View 0 chunks +-1 lines, --1 lines 0 comments Download
A blimp/client/core/resources/blimp_strings.cc View 1 chunk +78 lines, -0 lines 0 comments Download
A blimp/client/core/resources/blimp_strings.grd View 1 chunk +258 lines, -0 lines 0 comments Download
A blimp/client/core/resources/dummy_blimp_strings.cc View 1 chunk +21 lines, -0 lines 0 comments Download
A blimp/client/core/resources/dummy_blimp_strings.grd View 1 chunk +66 lines, -0 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_am.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_ar.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_bg.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_ca.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_cs.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_da.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_de.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_el.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_en-GB.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_es.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_es-419.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_fa.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_fi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_fil.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_fr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_hi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_hr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_hu.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_id.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_it.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_iw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_ja.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_ko.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_lt.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_lv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_nl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_no.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_pl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_pt-BR.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_pt-PT.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_ro.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_ru.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_sk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_sl.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_sr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_sv.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_sw.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_th.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_tr.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_uk.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_vi.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_zh-CN.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
A + blimp/client/core/resources/translations/blimp_strings_zh-TW.xtb View 0 chunks +-1 lines, --1 lines 0 comments Download
M blimp/client/core/settings/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M blimp/client/public/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M blimp/client/public/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M blimp/client/public/blimp_client_context_delegate.h View 1 chunk +1 line, -1 line 0 comments Download
A blimp/client/public/resources/BUILD.gn View 1 chunk +13 lines, -0 lines 0 comments Download
A blimp/client/public/resources/blimp_strings.h View 1 chunk +44 lines, -0 lines 0 comments Download
M build/android/lint/suppressions.xml View 3 chunks +3 lines, -0 lines 0 comments Download
M chrome/chrome_repack_locales.gni View 1 2 3 4 1 chunk +6 lines, -0 lines 0 comments Download
M tools/gritsettings/resource_ids View 1 chunk +3 lines, -0 lines 0 comments Download
M tools/gritsettings/translation_expectations.pyl View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 9 (9 generated)
xingliu
The CQ bit was checked by xingliu@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-22 02:41:39 UTC) #1
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447483002/20001
4 years, 2 months ago (2016-10-22 02:42:10 UTC) #2
xingliu
The CQ bit was checked by xingliu@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-22 03:00:04 UTC) #3
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447483002/40001
4 years, 2 months ago (2016-10-22 03:00:37 UTC) #4
xingliu
The CQ bit was checked by xingliu@chromium.org to run a CQ dry run
4 years, 2 months ago (2016-10-23 02:20:47 UTC) #5
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2447483002/80001
4 years, 2 months ago (2016-10-23 02:21:07 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
4 years, 2 months ago (2016-10-23 02:57:39 UTC) #7
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/150557)
4 years, 2 months ago (2016-10-23 02:57:40 UTC) #8
xingliu
4 years, 1 month ago (2016-11-14 18:04:11 UTC) #9 
Description was changed from

==========
Test win_clang compile only check in core/resources.


BUG=
==========

to

==========
NOT TO SUBMIT, development purpose only.

Test win_clang compile only check in core/resources.


BUG=
==========

Powered by Google App Engine
This is Rietveld 408576698