Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3587)

Unified Diff: blimp/client/public/resources/blimp_strings.h

Issue 2447483002: Test win_clang compile only check in core/resources. (Closed)
Patch Set: filter win platform build Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « blimp/client/public/resources/BUILD.gn ('k') | build/android/lint/suppressions.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: blimp/client/public/resources/blimp_strings.h
diff --git a/blimp/client/public/resources/blimp_strings.h b/blimp/client/public/resources/blimp_strings.h
new file mode 100644
index 0000000000000000000000000000000000000000..09be56d457c4f15e9a377e0b7acac6f6e46fb464
--- /dev/null
+++ b/blimp/client/public/resources/blimp_strings.h
@@ -0,0 +1,44 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_PUBLIC_RESOURCES_BLIMP_STRINGS_H_
+#define BLIMP_CLIENT_PUBLIC_RESOURCES_BLIMP_STRINGS_H_
+
+#include "base/macros.h"
+#include "blimp/client/public/session/assignment.h"
+#include "blimp/common/proto/protocol_control.pb.h"
+
+namespace blimp {
+namespace string {
+
+// Utilities to access internal Blimp strings.
+//
+// 1. Conditional compile based on |enable_blimp_client| GN flag.
+// if true, compiled with core/resources/blimp_strings.cc.
+// if false, compiled with core/resources/dummy_blimp_strings.cc, which returns
+// empty strings and doesn't build with internal resources.
+//
+// 2. Grit file generation.
+// The |grit/blimp_strings.h| header defines the string id,
+// and is auto-generated based on configuration in
+// |blimp/client/core/resources/blimp_strings.grd|, and
+// |tools/gritsettings/resource_ids|.
+// The actual strings are defined in |blimp_strings.grd|.
+//
+// 3. Public external strings, can be directly included for
+// |blimp/client/support/resources/blimp_strings.h|, and is generated from
+// |blimp/client/support/resources| build target.
+
+// Converts an AssignmentRequestResult to human readable string.
+base::string16 AssignmentResultErrorToString(
+ blimp::client::AssignmentRequestResult result);
+
+// Converts EndConnectionMessage::Reason to human readable string.
+base::string16 EndConnectionMessageToString(
+ EndConnectionMessage::Reason reason);
+
+} // namespace string
+} // namespace blimp
+
+#endif // BLIMP_CLIENT_PUBLIC_RESOURCES_BLIMP_STRINGS_H_
« no previous file with comments | « blimp/client/public/resources/BUILD.gn ('k') | build/android/lint/suppressions.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698