Media Controls: don't activate buttons when tapping on hidden controls.

Media Controls: don't activate buttons when tapping on hidden controls.

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648, 652698
Committed: https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2
Cr-Commit-Position: refs/heads/master@{#426452}

[mlamouri (slow - plz ping), 2016-10-18 16:49:36]

The CQ bit was checked by mlamouri@chromium.org to run a CQ dry run

[mlamouri (slow - plz ping), 2016-10-18 16:49:54]

mlamouri@chromium.org changed reviewers:
+ zqzhang@chromium.org

[mlamouri (slow - plz ping), 2016-10-18 16:49:55]

PTAL :)

[commit-bot: I haz the power, 2016-10-18 16:49:56]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-18 17:43:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 17:43:04]

Dry run: Try jobs failed on following builders:
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Zhiqiang Zhang (Slow), 2016-10-19 10:02:04]

lgtm w/ nit

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
(right):

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html:21:
eventSender.gestureTap(coords[0], coords[1]);
nit: maybe do the asserts after each gesture?

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:672: if
(!containsRelatedTarget(event)) {
IIUC, the following logic is to handle the event before it goes into the panel,
right?

[mlamouri (slow - plz ping), 2016-10-20 10:31:19]

The CQ bit was checked by mlamouri@chromium.org

[mlamouri (slow - plz ping), 2016-10-20 10:31:20]

The patchset sent to the CQ was uploaded after l-g-t-m from zqzhang@chromium.org
Link to the patchset: https://chromiumcodereview.appspot.com/2431583004/#ps60001
(title: "review comments")

[commit-bot: I haz the power, 2016-10-20 10:31:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[mlamouri (slow - plz ping), 2016-10-20 10:32:07]

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Layo...
File
third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html
(right):

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/media/media-controls-tap-show-controls-without-activating.html:21:
eventSender.gestureTap(coords[0], coords[1]);
On 2016/10/19 at 10:02:04, Zhiqiang Zhang wrote:
> nit: maybe do the asserts after each gesture?

Done.

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/html/shadow/MediaControls.cpp (right):

https://codereview.chromium.org/2431583004/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/html/shadow/MediaControls.cpp:672: if
(!containsRelatedTarget(event)) {
On 2016/10/19 at 10:02:04, Zhiqiang Zhang wrote:
> IIUC, the following logic is to handle the event before it goes into the
panel, right?

Only the "setDefaultHandled" (to avoid the default handlers to run).

The rest is to get the panel to show up for 3 seconds.

[commit-bot: I haz the power, 2016-10-20 11:54:01]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2016-10-21 13:17:28]

Description was changed from

==========
Media Controls: don't activate buttons when tapping on hidden controls.

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648,652698
==========

to

==========
Media Controls: don't activate buttons when tapping on hidden controls.

This should also fix an accessibility issue where activating the
controls while hidden would randomly activate one of the buttons.

BUG=654648,652698

Committed: https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2
Cr-Commit-Position: refs/heads/master@{#426452}
==========

[commit-bot: I haz the power, 2016-10-21 13:17:29]

Patchset 4 (id:??) landed as
https://crrev.com/cb55961999ccce51568d3fcdfbb51c8ba5bcfdb2
Cr-Commit-Position: refs/heads/master@{#426452}