third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp - Issue 2431583004: Media Controls: don't activate buttons when tapping on hidden controls.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

Issue 2431583004: Media Controls: don't activate buttons when tapping on hidden controls. (Closed)

Patch Set: review comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/MediaControlElements.h ('k') | third_party/WebKit/Source/core/html/shadow/MediaControls.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

index f9a769e38e3d3288e2079948a0fec80f6adb5875..ed01012ff4cb30e2c8a80bf5d6a1335c43686478 100644

--- a/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/MediaControlElements.cpp

@@ -174,6 +174,10 @@ void MediaControlPanelElement::didBecomeVisible() {

mediaElement().mediaControlsDidBecomeVisible();

}

+bool MediaControlPanelElement::isOpaque() const {

+ return m_opaque;

void MediaControlPanelElement::makeOpaque() {

if (m_opaque)

return;