Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(434)

Unified Diff: third_party/WebKit/Source/core/html/shadow/MediaControls.h

Issue 2431583004: Media Controls: don't activate buttons when tapping on hidden controls. (Closed)
Patch Set: review comments Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/shadow/MediaControls.h
diff --git a/third_party/WebKit/Source/core/html/shadow/MediaControls.h b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
index a450161efaad814b31b4cecaa777d482e4e12722..7a26cf52356fc37cc27ae69575e6c4f4242c3993 100644
--- a/third_party/WebKit/Source/core/html/shadow/MediaControls.h
+++ b/third_party/WebKit/Source/core/html/shadow/MediaControls.h
@@ -46,6 +46,7 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
void show();
void hide();
+ bool isVisible() const;
void playbackStarted();
void playbackProgressed();
@@ -122,7 +123,8 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
IgnoreNone = 0,
IgnoreVideoHover = 1 << 0,
IgnoreFocus = 1 << 1,
- IgnoreControlsHover = 1 << 2
+ IgnoreControlsHover = 1 << 2,
+ IgnoreWaitForTimer = 1 << 3,
};
bool shouldHideMediaControls(unsigned behaviorFlags = 0) const;
@@ -180,6 +182,7 @@ class CORE_EXPORT MediaControls final : public HTMLDivElement {
int m_panelWidth;
bool m_allowHiddenVolumeControls : 1;
+ bool m_keepShowingUntilTimerFires : 1;
};
DEFINE_ELEMENT_TYPE_CASTS(MediaControls, isMediaControls());

Powered by Google App Engine
This is Rietveld 408576698