Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(271)

Side by Side Diff: third_party/WebKit/Source/core/html/shadow/MediaControlElements.h

Issue 2431583004: Media Controls: don't activate buttons when tapping on hidden controls. (Closed)
Patch Set: review comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved. 2 * Copyright (C) 2008, 2009, 2010, 2011 Apple Inc. All rights reserved.
3 * Copyright (C) 2012 Google Inc. All rights reserved. 3 * Copyright (C) 2012 Google Inc. All rights reserved.
4 * 4 *
5 * Redistribution and use in source and binary forms, with or without 5 * Redistribution and use in source and binary forms, with or without
6 * modification, are permitted provided that the following conditions 6 * modification, are permitted provided that the following conditions
7 * are met: 7 * are met:
8 * 8 *
9 * 1. Redistributions of source code must retain the above copyright 9 * 1. Redistributions of source code must retain the above copyright
10 * notice, this list of conditions and the following disclaimer. 10 * notice, this list of conditions and the following disclaimer.
(...skipping 27 matching lines...) Expand all
38 class TextTrack; 38 class TextTrack;
39 39
40 // ---------------------------- 40 // ----------------------------
41 41
42 class MediaControlPanelElement final : public MediaControlDivElement { 42 class MediaControlPanelElement final : public MediaControlDivElement {
43 public: 43 public:
44 static MediaControlPanelElement* create(MediaControls&); 44 static MediaControlPanelElement* create(MediaControls&);
45 45
46 void setIsDisplayed(bool); 46 void setIsDisplayed(bool);
47 47
48 bool isOpaque() const;
48 void makeOpaque(); 49 void makeOpaque();
49 void makeTransparent(); 50 void makeTransparent();
50 51
51 private: 52 private:
52 explicit MediaControlPanelElement(MediaControls&); 53 explicit MediaControlPanelElement(MediaControls&);
53 54
54 void defaultEventHandler(Event*) override; 55 void defaultEventHandler(Event*) override;
55 bool keepEventInNode(Event*) override; 56 bool keepEventInNode(Event*) override;
56 57
57 void startTimer(); 58 void startTimer();
(...skipping 308 matching lines...) Expand 10 before | Expand all | Expand 10 after
366 public: 367 public:
367 static MediaControlCurrentTimeDisplayElement* create(MediaControls&); 368 static MediaControlCurrentTimeDisplayElement* create(MediaControls&);
368 369
369 private: 370 private:
370 explicit MediaControlCurrentTimeDisplayElement(MediaControls&); 371 explicit MediaControlCurrentTimeDisplayElement(MediaControls&);
371 }; 372 };
372 373
373 } // namespace blink 374 } // namespace blink
374 375
375 #endif // MediaControlElements_h 376 #endif // MediaControlElements_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698