Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Issue 2430813002: Switch to shorter names for property tree storage and updates (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-layout_chromium.org, blink-reviews-paint_chromium.org, chromium-reviews, dshwang, eae+blinkwatch, jchaffraix+rendering, leviw+renderwatch, pdr+renderingwatchlist_chromium.org, szager+layoutwatch_chromium.org, zoltan1
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Switch to shorter names for property tree storage and updates This patch has two changes to increase readability with our new, shorter line length. 1) "createOrUpdate*" has been renamed "update*". 2) LayoutObject's objectPaintProperties has been renamed "paintProperties". This includes related functions such as "ensurePaintProperties()", etc. There are no changes in behavior, just easier to read code. BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/bb580d050724948dcdf4a73068958729d937022d Cr-Commit-Position: refs/heads/master@{#426128}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+290 lines, -345 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutObject.h View 2 chunks +6 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutObject.cpp View 3 chunks +10 lines, -12 lines 0 comments Download
M third_party/WebKit/Source/core/layout/api/LayoutItem.h View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/BlockPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/BoxClipper.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ObjectPaintProperties.h View 1 chunk +28 lines, -34 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintControllerPaintTest.cpp View 1 chunk +1 line, -2 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintInvalidator.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerClipper.cpp View 4 chunks +8 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintLayerPainter.cpp View 2 chunks +4 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 28 chunks +62 lines, -86 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilderTest.cpp View 110 chunks +154 lines, -170 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinter.cpp View 2 chunks +2 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/core/paint/PaintPropertyTreePrinterTest.cpp View 4 chunks +5 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/core/paint/SVGPaintContext.h View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/paint/ScrollableAreaPainter.cpp View 1 chunk +1 line, -1 line 0 comments Download

Depends on Patchset:

Messages

Total messages: 14 (9 generated)
pdr.
Not strictly necessary but will make my work-in-progress incremental property tree patch easier to review. ...
4 years, 2 months ago (2016-10-18 21:42:41 UTC) #3
Xianzhu
lgtm
4 years, 2 months ago (2016-10-18 21:56:54 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2430813002/1
4 years, 2 months ago (2016-10-19 02:43:37 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 03:53:40 UTC) #12
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:06:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb580d050724948dcdf4a73068958729d937022d
Cr-Commit-Position: refs/heads/master@{#426128}

Powered by Google App Engine
This is Rietveld 408576698