Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(627)

Issue 2425183003: Refactor FrameView property updates to work like LayouObject updates (Closed)

Created:
4 years, 2 months ago by pdr.
Modified:
4 years, 2 months ago
Reviewers:
chrishtr, Xianzhu
CC:
blink-reviews, blink-reviews-paint_chromium.org, chromium-reviews, dshwang
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Refactor FrameView property updates to work like LayouObject updates PaintPropertyTreeBuilder::buildTreeNodes worked differently for FrameView because newly-updated nodes were not returned from the createOrUpdateFunctions. With this patch, FrameView's property updates work just like the other LayoutObject property updates throughout PaintPropertyTreeBuilder. This patch will make it easier to perform future refactorings of the property updates. BUG=645667 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_layout_tests_slimming_paint_v2 Committed: https://crrev.com/b55cdc3b2b1a077b890648a6c4510569a124e761 Cr-Commit-Position: refs/heads/master@{#426121}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -22 lines) Patch
M third_party/WebKit/Source/core/paint/PaintPropertyTreeBuilder.cpp View 8 chunks +24 lines, -22 lines 0 comments Download

Dependent Patchsets:

Messages

Total messages: 17 (10 generated)
pdr.
4 years, 2 months ago (2016-10-18 20:54:01 UTC) #4
Xianzhu
lgtm
4 years, 2 months ago (2016-10-18 20:59:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425183003/1
4 years, 2 months ago (2016-10-18 23:37:51 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_android_rel_ng/builds/162904)
4 years, 2 months ago (2016-10-19 01:35:12 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2425183003/1
4 years, 2 months ago (2016-10-19 01:39:52 UTC) #14
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 2 months ago (2016-10-19 02:37:47 UTC) #15
commit-bot: I haz the power
4 years, 2 months ago (2016-10-21 13:05:57 UTC) #17
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b55cdc3b2b1a077b890648a6c4510569a124e761
Cr-Commit-Position: refs/heads/master@{#426121}

Powered by Google App Engine
This is Rietveld 408576698