Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(697)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutObject.h

Issue 2430813002: Switch to shorter names for property tree storage and updates (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 2000 Lars Knoll (knoll@kde.org)
3 * (C) 2000 Antti Koivisto (koivisto@kde.org) 3 * (C) 2000 Antti Koivisto (koivisto@kde.org)
4 * (C) 2000 Dirk Mueller (mueller@kde.org) 4 * (C) 2000 Dirk Mueller (mueller@kde.org)
5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com) 5 * (C) 2004 Allan Sandfeld Jensen (kde@carewolf.com)
6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc. 6 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2012 Apple Inc.
7 * All rights reserved. 7 * All rights reserved.
8 * Copyright (C) 2009 Google Inc. All rights reserved. 8 * Copyright (C) 2009 Google Inc. All rights reserved.
9 * 9 *
10 * This library is free software; you can redistribute it and/or 10 * This library is free software; you can redistribute it and/or
(...skipping 398 matching lines...) Expand 10 before | Expand all | Expand 10 after
409 virtual bool createsAnonymousWrapper() const { return false; } 409 virtual bool createsAnonymousWrapper() const { return false; }
410 ////////////////////////////////////////// 410 //////////////////////////////////////////
411 411
412 // Sets the parent of this object but doesn't add it as a child of the parent. 412 // Sets the parent of this object but doesn't add it as a child of the parent.
413 void setDangerousOneWayParent(LayoutObject*); 413 void setDangerousOneWayParent(LayoutObject*);
414 414
415 // For SPv2 only. The ObjectPaintProperties structure holds references to the 415 // For SPv2 only. The ObjectPaintProperties structure holds references to the
416 // property tree nodes that are created by the layout object for painting. 416 // property tree nodes that are created by the layout object for painting.
417 // The property nodes are only updated during InUpdatePaintProperties phase 417 // The property nodes are only updated during InUpdatePaintProperties phase
418 // of the document lifecycle and shall remain immutable during other phases. 418 // of the document lifecycle and shall remain immutable during other phases.
419 const ObjectPaintProperties* objectPaintProperties() const; 419 const ObjectPaintProperties* paintProperties() const;
420 420
421 private: 421 private:
422 ObjectPaintProperties& ensureObjectPaintProperties(); 422 ObjectPaintProperties& ensurePaintProperties();
423 423
424 private: 424 private:
425 ////////////////////////////////////////// 425 //////////////////////////////////////////
426 // Helper functions. Dangerous to use! 426 // Helper functions. Dangerous to use!
427 void setPreviousSibling(LayoutObject* previous) { m_previous = previous; } 427 void setPreviousSibling(LayoutObject* previous) { m_previous = previous; }
428 void setNextSibling(LayoutObject* next) { m_next = next; } 428 void setNextSibling(LayoutObject* next) { m_next = next; }
429 void setParent(LayoutObject* parent) { 429 void setParent(LayoutObject* parent) {
430 m_parent = parent; 430 m_parent = parent;
431 431
432 // Only update if our flow thread state is different from our new parent and 432 // Only update if our flow thread state is different from our new parent and
(...skipping 1287 matching lines...) Expand 10 before | Expand all | Expand 10 after
1720 m_layoutObject.setPreviousBackgroundObscured(b); 1720 m_layoutObject.setPreviousBackgroundObscured(b);
1721 } 1721 }
1722 void clearPreviousPaintInvalidationRects() { 1722 void clearPreviousPaintInvalidationRects() {
1723 m_layoutObject.clearPreviousPaintInvalidationRects(); 1723 m_layoutObject.clearPreviousPaintInvalidationRects();
1724 } 1724 }
1725 1725
1726 protected: 1726 protected:
1727 friend class PaintPropertyTreeBuilder; 1727 friend class PaintPropertyTreeBuilder;
1728 // The following two functions can be called from PaintPropertyTreeBuilder 1728 // The following two functions can be called from PaintPropertyTreeBuilder
1729 // only. 1729 // only.
1730 ObjectPaintProperties& ensureObjectPaintProperties() { 1730 ObjectPaintProperties& ensurePaintProperties() {
1731 return m_layoutObject.ensureObjectPaintProperties(); 1731 return m_layoutObject.ensurePaintProperties();
1732 } 1732 }
1733 ObjectPaintProperties* objectPaintProperties() { 1733 ObjectPaintProperties* paintProperties() {
1734 return const_cast<ObjectPaintProperties*>( 1734 return const_cast<ObjectPaintProperties*>(
1735 m_layoutObject.objectPaintProperties()); 1735 m_layoutObject.paintProperties());
1736 } 1736 }
1737 1737
1738 friend class LayoutObject; 1738 friend class LayoutObject;
1739 MutableForPainting(const LayoutObject& layoutObject) 1739 MutableForPainting(const LayoutObject& layoutObject)
1740 : m_layoutObject(const_cast<LayoutObject&>(layoutObject)) {} 1740 : m_layoutObject(const_cast<LayoutObject&>(layoutObject)) {}
1741 1741
1742 LayoutObject& m_layoutObject; 1742 LayoutObject& m_layoutObject;
1743 }; 1743 };
1744 MutableForPainting getMutableForPainting() const { 1744 MutableForPainting getMutableForPainting() const {
1745 return MutableForPainting(*this); 1745 return MutableForPainting(*this);
(...skipping 851 matching lines...) Expand 10 before | Expand all | Expand 10 after
2597 CORE_EXPORT void showLineTree(const blink::LayoutObject*); 2597 CORE_EXPORT void showLineTree(const blink::LayoutObject*);
2598 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1); 2598 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1);
2599 // We don't make object2 an optional parameter so that showLayoutTree 2599 // We don't make object2 an optional parameter so that showLayoutTree
2600 // can be called from gdb easily. 2600 // can be called from gdb easily.
2601 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1, 2601 CORE_EXPORT void showLayoutTree(const blink::LayoutObject* object1,
2602 const blink::LayoutObject* object2); 2602 const blink::LayoutObject* object2);
2603 2603
2604 #endif 2604 #endif
2605 2605
2606 #endif // LayoutObject_h 2606 #endif // LayoutObject_h
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutObject.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698