Remove all synchronous methods from OfflinePageBridge.

Remove all synchronous methods from OfflinePageBridge.

This blocks adding features to the query interface, which is asynchronous by design.

BUG=589526, 622763
Committed: https://crrev.com/4af0fc42ddb3a671b7e71541fe3a7815de26a0a1
Cr-Commit-Position: refs/heads/master@{#426805}

[dewittj, 2016-10-18 21:26:49]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 21:27:30]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-10-18 22:38:08]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-18 22:38:48]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-10-18 22:41:46]

Description was changed from

==========
Remove all synchronous methods from OfflinePageBridge.

BUG=589526,622763
==========

to

==========
Remove all synchronous methods from OfflinePageBridge.

This blocks adding features to the query interface, which is asynchronous by
design.

BUG=589526,622763
==========

[dewittj, 2016-10-18 22:41:46]

dewittj@chromium.org changed reviewers:
+ jianli@chromium.org

[dewittj, 2016-10-18 22:42:12]

ptal, thanks!

[commit-bot: I haz the power, 2016-10-18 23:10:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-18 23:10:41]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[jianli, 2016-10-19 00:21:38]

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model.h (right):

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model.h:106: // Deletes all pages with a
client ID equal to one in |client_ids|.
The comment "with a client ID equal to one in |client_ids|" is a bit hard to
understand. How about:
  Deletes all pages associated with any of |client_ids|.

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model.h:110: // Retrieves all pages with a
client ID equal to one in |client_ids|.
ditto

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:443:
std::sort(sorted_client_ids.begin(), sorted_client_ids.end());
Why not using a set?

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:468:
std::sort(sorted_client_ids.begin(), sorted_client_ids.end());
ditto

[dewittj, 2016-10-19 16:17:53]

The CQ bit was checked by dewittj@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-19 16:18:13]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[dewittj, 2016-10-19 16:18:33]

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model.h (right):

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model.h:106: // Deletes all pages with a
client ID equal to one in |client_ids|.
On 2016/10/19 00:21:37, jianli wrote:
> The comment "with a client ID equal to one in |client_ids|" is a bit hard to
> understand. How about:
>   Deletes all pages associated with any of |client_ids|.

Done.

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model.h:110: // Retrieves all pages with a
client ID equal to one in |client_ids|.
On 2016/10/19 00:21:37, jianli wrote:
> ditto

Done.

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
File components/offline_pages/offline_page_model_impl.cc (right):

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:443:
std::sort(sorted_client_ids.begin(), sorted_client_ids.end());
On 2016/10/19 00:21:37, jianli wrote:
> Why not using a set?

Done.

The b-tree seemed like too much overhead for this operation.  Maybe not..

https://codereview.chromium.org/2429943002/diff/20001/components/offline_page...
components/offline_pages/offline_page_model_impl.cc:468:
std::sort(sorted_client_ids.begin(), sorted_client_ids.end());
On 2016/10/19 00:21:37, jianli wrote:
> ditto

Done.

[commit-bot: I haz the power, 2016-10-19 17:16:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-19 17:16:54]

Dry run: This issue passed the CQ dry run.

[dewittj, 2016-10-20 17:31:31]

dewittj@chromium.org changed reviewers:
+ fgorski@chromium.org
- jianli@chromium.org

[dewittj, 2016-10-20 17:31:31]

-> fgorski since jianli might be out today

PTAL, thanks!

[jianli, 2016-10-20 20:49:00]

jianli@chromium.org changed reviewers:
+ jianli@chromium.org

[jianli, 2016-10-20 20:49:01]

lgtm

[dewittj, 2016-10-21 15:14:11]

The CQ bit was checked by dewittj@chromium.org

[commit-bot: I haz the power, 2016-10-21 15:14:29]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-21 16:09:25]

Description was changed from

==========
Remove all synchronous methods from OfflinePageBridge.

This blocks adding features to the query interface, which is asynchronous by
design.

BUG=589526,622763
==========

to

==========
Remove all synchronous methods from OfflinePageBridge.

This blocks adding features to the query interface, which is asynchronous by
design.

BUG=589526,622763
==========

[commit-bot: I haz the power, 2016-10-21 16:09:26]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-21 16:35:03]

Description was changed from

==========
Remove all synchronous methods from OfflinePageBridge.

This blocks adding features to the query interface, which is asynchronous by
design.

BUG=589526,622763
==========

to

==========
Remove all synchronous methods from OfflinePageBridge.

This blocks adding features to the query interface, which is asynchronous by
design.

BUG=589526,622763

Committed: https://crrev.com/4af0fc42ddb3a671b7e71541fe3a7815de26a0a1
Cr-Commit-Position: refs/heads/master@{#426805}
==========

[commit-bot: I haz the power, 2016-10-21 16:35:04]

Patchset 3 (id:??) landed as
https://crrev.com/4af0fc42ddb3a671b7e71541fe3a7815de26a0a1
Cr-Commit-Position: refs/heads/master@{#426805}