Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(381)

Side by Side Diff: chrome/browser/android/offline_pages/offline_page_bridge.h

Issue 2429943002: Remove all synchronous methods from OfflinePageBridge. (Closed)
Patch Set: Fix a test and address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_ 5 #ifndef CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_ 6 #define CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include "base/android/jni_android.h" 10 #include "base/android/jni_android.h"
(...skipping 37 matching lines...) Expand 10 before | Expand all | Expand 10 after
48 JNIEnv* env, 48 JNIEnv* env,
49 const base::android::JavaParamRef<jobject>& obj, 49 const base::android::JavaParamRef<jobject>& obj,
50 const base::android::JavaParamRef<jobjectArray>& j_urls_array, 50 const base::android::JavaParamRef<jobjectArray>& j_urls_array,
51 const base::android::JavaParamRef<jobject>& j_callback_obj); 51 const base::android::JavaParamRef<jobject>& j_callback_obj);
52 52
53 void GetAllPages(JNIEnv* env, 53 void GetAllPages(JNIEnv* env,
54 const base::android::JavaParamRef<jobject>& obj, 54 const base::android::JavaParamRef<jobject>& obj,
55 const base::android::JavaParamRef<jobject>& j_result_obj, 55 const base::android::JavaParamRef<jobject>& j_result_obj,
56 const base::android::JavaParamRef<jobject>& j_callback_obj); 56 const base::android::JavaParamRef<jobject>& j_callback_obj);
57 57
58 base::android::ScopedJavaLocalRef<jlongArray> GetOfflineIdsForClientId( 58 void GetPageByOfflineId(
59 JNIEnv* env, 59 JNIEnv* env,
60 const base::android::JavaParamRef<jobject>& obj, 60 const base::android::JavaParamRef<jobject>& obj,
61 const base::android::JavaParamRef<jstring>& j_namespace, 61 jlong offline_id,
62 const base::android::JavaParamRef<jstring>& j_client_id); 62 const base::android::JavaParamRef<jobject>& j_callback_obj);
63 63
64 base::android::ScopedJavaLocalRef<jobject> GetPageByOfflineId( 64 void DeletePagesByClientId(
65 JNIEnv* env, 65 JNIEnv* env,
66 const base::android::JavaParamRef<jobject>& obj, 66 const base::android::JavaParamRef<jobject>& obj,
67 jlong offline_id); 67 const base::android::JavaParamRef<jobjectArray>& j_namespaces_array,
68 const base::android::JavaParamRef<jobjectArray>& j_ids_array,
69 const base::android::JavaParamRef<jobject>& j_callback_obj);
70
71 void GetPagesByClientId(
72 JNIEnv* env,
73 const base::android::JavaParamRef<jobject>& obj,
74 const base::android::JavaParamRef<jobject>& j_result_obj,
75 const base::android::JavaParamRef<jobjectArray>& j_namespaces_array,
76 const base::android::JavaParamRef<jobjectArray>& j_ids_array,
77 const base::android::JavaParamRef<jobject>& j_callback_obj);
68 78
69 void SelectPageForOnlineUrl( 79 void SelectPageForOnlineUrl(
70 JNIEnv* env, 80 JNIEnv* env,
71 const base::android::JavaParamRef<jobject>& obj, 81 const base::android::JavaParamRef<jobject>& obj,
72 const base::android::JavaParamRef<jstring>& j_online_url, 82 const base::android::JavaParamRef<jstring>& j_online_url,
73 int tab_id, 83 int tab_id,
74 const base::android::JavaParamRef<jobject>& j_callback_obj); 84 const base::android::JavaParamRef<jobject>& j_callback_obj);
75 85
76 void SavePage( 86 void SavePage(
77 JNIEnv* env, 87 JNIEnv* env,
78 const base::android::JavaParamRef<jobject>& obj, 88 const base::android::JavaParamRef<jobject>& obj,
79 const base::android::JavaParamRef<jobject>& j_callback_obj, 89 const base::android::JavaParamRef<jobject>& j_callback_obj,
80 const base::android::JavaParamRef<jobject>& j_web_contents, 90 const base::android::JavaParamRef<jobject>& j_web_contents,
81 const base::android::JavaParamRef<jstring>& j_namespace, 91 const base::android::JavaParamRef<jstring>& j_namespace,
82 const base::android::JavaParamRef<jstring>& j_client_id); 92 const base::android::JavaParamRef<jstring>& j_client_id);
83 93
84 void SavePageLater(JNIEnv* env, 94 void SavePageLater(JNIEnv* env,
85 const base::android::JavaParamRef<jobject>& obj, 95 const base::android::JavaParamRef<jobject>& obj,
86 const base::android::JavaParamRef<jstring>& url, 96 const base::android::JavaParamRef<jstring>& url,
87 const base::android::JavaParamRef<jstring>& j_namespace, 97 const base::android::JavaParamRef<jstring>& j_namespace,
88 const base::android::JavaParamRef<jstring>& j_client_id, 98 const base::android::JavaParamRef<jstring>& j_client_id,
89 jboolean user_requested); 99 jboolean user_requested);
90 100
91 void DeletePages(
92 JNIEnv* env,
93 const base::android::JavaParamRef<jobject>& obj,
94 const base::android::JavaParamRef<jobject>& j_callback_obj,
95 const base::android::JavaParamRef<jlongArray>& j_offline_ids_array);
96
97 base::android::ScopedJavaLocalRef<jstring> GetOfflinePageHeaderForReload( 101 base::android::ScopedJavaLocalRef<jstring> GetOfflinePageHeaderForReload(
98 JNIEnv* env, 102 JNIEnv* env,
99 const base::android::JavaParamRef<jobject>& obj, 103 const base::android::JavaParamRef<jobject>& obj,
100 const base::android::JavaParamRef<jobject>& j_web_contents); 104 const base::android::JavaParamRef<jobject>& j_web_contents);
101 105
102 void GetRequestsInQueue( 106 void GetRequestsInQueue(
103 JNIEnv* env, 107 JNIEnv* env,
104 const base::android::JavaParamRef<jobject>& obj, 108 const base::android::JavaParamRef<jobject>& obj,
105 const base::android::JavaParamRef<jobject>& j_callback_obj); 109 const base::android::JavaParamRef<jobject>& j_callback_obj);
106 110
(...skipping 21 matching lines...) Expand all
128 DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge); 132 DISALLOW_COPY_AND_ASSIGN(OfflinePageBridge);
129 }; 133 };
130 134
131 bool RegisterOfflinePageBridge(JNIEnv* env); 135 bool RegisterOfflinePageBridge(JNIEnv* env);
132 136
133 } // namespace android 137 } // namespace android
134 } // namespace offline_pages 138 } // namespace offline_pages
135 139
136 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_ 140 #endif // CHROME_BROWSER_ANDROID_OFFLINE_PAGES_OFFLINE_PAGE_BRIDGE_H_
137 141
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698