Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: components/offline_pages/stub_offline_page_model.cc

Issue 2429943002: Remove all synchronous methods from OfflinePageBridge. (Closed)
Patch Set: Fix a test and address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/offline_pages/stub_offline_page_model.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/offline_pages/stub_offline_page_model.cc
diff --git a/components/offline_pages/stub_offline_page_model.cc b/components/offline_pages/stub_offline_page_model.cc
index aff22ddd092cee503872c63f1594785795638bc1..66efb1ed00ca1f17f0960f83fb20cf15727a3ff3 100644
--- a/components/offline_pages/stub_offline_page_model.cc
+++ b/components/offline_pages/stub_offline_page_model.cc
@@ -21,6 +21,12 @@ void StubOfflinePageModel::MarkPageAccessed(int64_t offline_id) {}
void StubOfflinePageModel::DeletePagesByOfflineId(
const std::vector<int64_t>& offline_ids,
const DeletePageCallback& callback) {}
+void StubOfflinePageModel::DeletePagesByClientIds(
+ const std::vector<ClientId>& client_ids,
+ const DeletePageCallback& callback) {}
+void StubOfflinePageModel::GetPagesByClientIds(
+ const std::vector<ClientId>& client_ids,
+ const MultipleOfflinePageItemCallback& callback) {}
void StubOfflinePageModel::DeleteCachedPagesByURLPredicate(
const UrlPredicate& predicate,
const DeletePageCallback& callback) {}
@@ -34,25 +40,12 @@ void StubOfflinePageModel::GetAllPagesWithExpired(
void StubOfflinePageModel::GetOfflineIdsForClientId(
const ClientId& client_id,
const MultipleOfflineIdCallback& callback) {}
-const std::vector<int64_t> StubOfflinePageModel::MaybeGetOfflineIdsForClientId(
- const ClientId& client_id) const {
- std::vector<int64_t> offline_ids;
- return offline_ids;
-}
void StubOfflinePageModel::GetPageByOfflineId(
int64_t offline_id,
const SingleOfflinePageItemCallback& callback) {}
-const OfflinePageItem* StubOfflinePageModel::MaybeGetPageByOfflineId(
- int64_t offline_id) const {
- return nullptr;
-}
void StubOfflinePageModel::GetPagesByOnlineURL(
const GURL& online_url,
const MultipleOfflinePageItemCallback& callback) {}
-const OfflinePageItem* StubOfflinePageModel::MaybeGetBestPageForOnlineURL(
- const GURL& online_url) const {
- return nullptr;
-}
void StubOfflinePageModel::ExpirePages(
const std::vector<int64_t>& offline_ids,
const base::Time& expiration_time,
« no previous file with comments | « components/offline_pages/stub_offline_page_model.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698