Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1101)

Unified Diff: components/offline_pages/offline_page_model_impl.cc

Issue 2429943002: Remove all synchronous methods from OfflinePageBridge. (Closed)
Patch Set: Fix a test and address nits. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/offline_pages/offline_page_model_impl.cc
diff --git a/components/offline_pages/offline_page_model_impl.cc b/components/offline_pages/offline_page_model_impl.cc
index 0a5094fb876b41b3e04a0327b3c3871d1ad70f10..053a023806275edfc54fd49a583027ddbb63f713 100644
--- a/components/offline_pages/offline_page_model_impl.cc
+++ b/components/offline_pages/offline_page_model_impl.cc
@@ -428,6 +428,51 @@ void OfflinePageModelImpl::DoDeletePagesByOfflineId(
weak_ptr_factory_.GetWeakPtr(), offline_ids, callback));
}
+void OfflinePageModelImpl::DeletePagesByClientIds(
+ const std::vector<ClientId>& client_ids,
+ const DeletePageCallback& callback) {
+ RunWhenLoaded(base::Bind(&OfflinePageModelImpl::DoDeletePagesByClientIds,
+ weak_ptr_factory_.GetWeakPtr(), client_ids,
+ callback));
+}
+
+void OfflinePageModelImpl::DoDeletePagesByClientIds(
+ const std::vector<ClientId>& client_ids,
+ const DeletePageCallback& callback) {
+ std::set<ClientId> client_id_set(client_ids.begin(), client_ids.end());
+
+ std::vector<int64_t> offline_ids;
+ for (const auto& page_pair : offline_pages_) {
+ if (client_id_set.count(page_pair.second.client_id) > 0)
+ offline_ids.emplace_back(page_pair.first);
+ }
+
+ DoDeletePagesByOfflineId(offline_ids, callback);
+}
+
+void OfflinePageModelImpl::GetPagesByClientIds(
+ const std::vector<ClientId>& client_ids,
+ const MultipleOfflinePageItemCallback& callback) {
+ RunWhenLoaded(base::Bind(&OfflinePageModelImpl::DoGetPagesByClientIds,
+ weak_ptr_factory_.GetWeakPtr(), client_ids,
+ callback));
+}
+
+void OfflinePageModelImpl::DoGetPagesByClientIds(
+ const std::vector<ClientId>& client_ids,
+ const MultipleOfflinePageItemCallback& callback) {
+ std::set<ClientId> client_id_set(client_ids.begin(), client_ids.end());
+
+ std::vector<OfflinePageItem> result;
+ for (const auto& page_pair : offline_pages_) {
+ if (!page_pair.second.IsExpired() &&
+ client_id_set.count(page_pair.second.client_id) > 0) {
+ result.emplace_back(page_pair.second);
+ }
+ }
+ callback.Run(result);
+}
+
void OfflinePageModelImpl::DeleteCachedPagesByURLPredicate(
const UrlPredicate& predicate,
const DeletePageCallback& callback) {
@@ -595,19 +640,6 @@ void OfflinePageModelImpl::GetPagesByOnlineURLWhenLoadDone(
callback.Run(result);
}
-const OfflinePageItem* OfflinePageModelImpl::MaybeGetBestPageForOnlineURL(
- const GURL& online_url) const {
- const OfflinePageItem* result = nullptr;
- for (const auto& id_page_pair : offline_pages_) {
- if (id_page_pair.second.url == online_url &&
- !id_page_pair.second.IsExpired()) {
- if (!result || id_page_pair.second.creation_time > result->creation_time)
- result = &(id_page_pair.second);
- }
- }
- return result;
-}
-
void OfflinePageModelImpl::CheckMetadataConsistency() {
DCHECK(is_loaded_);
archive_manager_->GetAllArchives(
« no previous file with comments | « components/offline_pages/offline_page_model_impl.h ('k') | components/offline_pages/offline_page_model_impl_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698