Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(425)

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed)

Created:
7 years, 3 months ago by rmacnak
Modified:
7 years, 3 months ago
CC:
reviews_dartlang.org, ahe, kasperl, gbracha
Visibility:
Public.

Description

Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) R=mlippautz@google.com Committed: https://code.google.com/p/dart/source/detail?r=27773

Patch Set 1 #

Total comments: 1

Patch Set 2 : merge line #

Unified diffs Side-by-side diffs Delta from patch set Stats (+146 lines, -150 lines) Patch
M tests/lib/mirrors/class_mirror_type_variables_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib/mirrors/equality_test.dart View 2 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/fake_function_test.dart View 2 chunks +12 lines, -14 lines 0 comments Download
M tests/lib/mirrors/function_type_mirror_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/lib/mirrors/inherit_field_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/intercepted_cache_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M tests/lib/mirrors/invoke_throws_test.dart View 1 chunk +14 lines, -14 lines 0 comments Download
M tests/lib/mirrors/is_odd_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/lazy_static_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/libraries_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/library_metadata_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/metadata_constructed_constant_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/metadata_test.dart View 1 chunk +6 lines, -6 lines 0 comments Download
M tests/lib/mirrors/method_mirror_properties_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/lib/mirrors/method_mirror_returntype_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/lib/mirrors/method_mirror_source_test.dart View 1 chunk +8 lines, -8 lines 0 comments Download
M tests/lib/mirrors/mirrors_resolve_fields_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/null_test.dart View 1 chunk +9 lines, -9 lines 0 comments Download
M tests/lib/mirrors/parameter_metadata_test.dart View 2 chunks +13 lines, -13 lines 0 comments Download
M tests/lib/mirrors/parameter_test.dart View 1 10 chunks +15 lines, -17 lines 0 comments Download
M tests/lib/mirrors/redirecting_factory_test.dart View 2 chunks +13 lines, -13 lines 0 comments Download
M tests/lib/mirrors/reflectively_instantiate_uninstantiated_class_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/return_type_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/to_string_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/top_level_accessors_test.dart View 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/typevariable_mirror_metadata_test.dart View 2 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
rmacnak
7 years, 3 months ago (2013-09-20 18:27:54 UTC) #1
Michael Lippautz (Google)
lgtm https://chromiumcodereview.appspot.com/24239010/diff/1/tests/lib/mirrors/parameter_test.dart File tests/lib/mirrors/parameter_test.dart (right): https://chromiumcodereview.appspot.com/24239010/diff/1/tests/lib/mirrors/parameter_test.dart#newcode51 tests/lib/mirrors/parameter_test.dart:51: #B, #B.bar, #B.baz, fits on one line?
7 years, 3 months ago (2013-09-20 21:11:16 UTC) #2
hausner
DBC: looking at this code, I wish we had designed Symbol literals as #"abc" instead ...
7 years, 3 months ago (2013-09-22 04:28:19 UTC) #3
rmacnak
7 years, 3 months ago (2013-09-23 16:17:44 UTC) #4
Message was sent while issue was closed.
Committed patchset #2 manually as r27773 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698