Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(358)

Unified Diff: tests/lib/mirrors/fake_function_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: merge line Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tests/lib/mirrors/equality_test.dart ('k') | tests/lib/mirrors/function_type_mirror_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tests/lib/mirrors/fake_function_test.dart
diff --git a/tests/lib/mirrors/fake_function_test.dart b/tests/lib/mirrors/fake_function_test.dart
index a824be0989a794b36eebf156dcaf37fa9d766074..058a5675ffda20ee449e051a4440acdfa3763825 100644
--- a/tests/lib/mirrors/fake_function_test.dart
+++ b/tests/lib/mirrors/fake_function_test.dart
@@ -15,12 +15,12 @@ main() {
Expect.isTrue(new WannabeFunction() is Function);
ClosureMirror cm = reflect(new WannabeFunction());
- Expect.equals(7, cm.invoke(const Symbol("call"), [3,4]).reflectee);
- Expect.throws(() => cm.invoke(const Symbol("call"), [3]),
+ Expect.equals(7, cm.invoke(#call, [3,4]).reflectee);
+ Expect.throws(() => cm.invoke(#call, [3]),
(e) => e is NoSuchMethodError,
"Wrong arity");
- Expect.equals(49, cm.invoke(const Symbol("method"), [7]).reflectee);
- Expect.throws(() => cm.invoke(const Symbol("method"), [3, 4]),
+ Expect.equals(49, cm.invoke(#method, [7]).reflectee);
+ Expect.throws(() => cm.invoke(#method, [3, 4]),
(e) => e is NoSuchMethodError,
"Wrong arity");
Expect.equals(7, cm.apply([3,4]).reflectee);
@@ -29,18 +29,16 @@ main() {
"Wrong arity");
MethodMirror mm = cm.function;
- Expect.equals(const Symbol("call"), mm.simpleName);
- Expect.equals(reflectClass(WannabeFunction),
- mm.owner);
+ Expect.equals(#call, mm.simpleName);
+ Expect.equals(reflectClass(WannabeFunction), mm.owner);
Expect.isTrue(mm.isRegularMethod);
- Expect.equals(const Symbol("int"), mm.returnType.simpleName);
- Expect.equals(const Symbol("int"), mm.parameters[0].type.simpleName);
- Expect.equals(const Symbol("int"), mm.parameters[1].type.simpleName);
+ Expect.equals(#int, mm.returnType.simpleName);
+ Expect.equals(#int, mm.parameters[0].type.simpleName);
+ Expect.equals(#int, mm.parameters[1].type.simpleName);
ClassMirror km = cm.type;
Expect.equals(reflectClass(WannabeFunction), km);
- Expect.equals(const Symbol("WannabeFunction"), km.simpleName);
- Expect.equals(mm, km.members[const Symbol("call")]);
- Expect.setEquals([const Symbol("call"), const Symbol("method")],
- km.members.keys);
+ Expect.equals(#WannabeFunction, km.simpleName);
+ Expect.equals(mm, km.members[#call]);
+ Expect.setEquals([#call, #method], km.members.keys);
}
« no previous file with comments | « tests/lib/mirrors/equality_test.dart ('k') | tests/lib/mirrors/function_type_mirror_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698