tests/lib/mirrors/return_type_test.dart - Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tests/lib/mirrors/return_type_test.dart

Issue 24239010: Use symbol literals in the mirror tests. (Except for void, the empty string and setters.) (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart

Patch Set: merge line Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tests/lib/mirrors/reflectively_instantiate_uninstantiated_class_test.dart ('k') | tests/lib/mirrors/to_string_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tests/lib/mirrors/return_type_test.dart

diff --git a/tests/lib/mirrors/return_type_test.dart b/tests/lib/mirrors/return_type_test.dart

index ebc208ad552c0c3cdac5196e6ba92ab6e054be86..6b90061cc8325bc9dde6a04dd3b1123e98693a6f 100644

--- a/tests/lib/mirrors/return_type_test.dart

+++ b/tests/lib/mirrors/return_type_test.dart

@@ -28,10 +28,10 @@ main() {

'h: Method(s(h) in s(B)), '

'i: Method(s(i) in s(B))}', methods);

- var f = methods[const Symbol('f')];

- var g = methods[const Symbol('g')];

- var h = methods[const Symbol('h')];

- var i = methods[const Symbol('i')];

+ var f = methods[#f];

+ var g = methods[#g];

+ var h = methods[#h];

+ var i = methods[#i];

expect('Type(s(dynamic), top-level)', f.returnType);

expect('Class(s(int) in s(dart.core), top-level)', g.returnType);

« no previous file with comments | « tests/lib/mirrors/reflectively_instantiate_uninstantiated_class_test.dart ('k') | tests/lib/mirrors/to_string_test.dart » ('j') | no next file with comments »