Improve generated "Not enough arguments." TypeError exceptions.

Improve generated "Not enough arguments." TypeError exceptions.

BUG=270033
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157966

[Mike West, 2013-09-17 13:08:28]

Hi Marja,

This CL migrates "Not enough arguments." exception messages over to the new
`ExceptionMessages::xxx` hotness, and paves the way for improving the (many)
other exceptions we throw in the bindings. Would you mind taking a look at the
patch in your copious free time?

Thanks!

-mike

[Mike West, 2013-09-18 10:16:07]

Mind taking another look at this, Marja? Should be less full of "FAIL ..." test
results. Also, should pass the other tests on the bots. :)

[marja, 2013-09-18 10:24:07]

https://codereview.chromium.org/24203002/diff/5001/LayoutTests/fast/canvas/dr...
File LayoutTests/fast/canvas/drawImage-with-valid-image.html (right):

https://codereview.chromium.org/24203002/diff/5001/LayoutTests/fast/canvas/dr...
LayoutTests/fast/canvas/drawImage-with-valid-image.html:156: </html>
What's this?

https://codereview.chromium.org/24203002/diff/5001/Source/bindings/scripts/de...
File Source/bindings/scripts/deprecated_code_generator_v8.pm (right):

https://codereview.chromium.org/24203002/diff/5001/Source/bindings/scripts/de...
Source/bindings/scripts/deprecated_code_generator_v8.pm:2096: $code .= "       
throwTypeError(ExceptionMessages::failedToExecute(\"$name\", \"$implClassName\",
\"$leastNumMandatoryParams argument" . ($leastNumMandatoryParams > 1 ? "s" : "")
 . " required, but only \" + String::number(args.Length()) + \" present.\"),
args.GetIsolate());\n";
Would it make sense to add a func to ExceptionMessages which produces a string
like:

"X argument(s) required but only Y present."

so that not all the places would need to construct the detail string themselves?

[Mike West, 2013-09-18 11:16:34]

https://codereview.chromium.org/24203002/diff/5001/LayoutTests/fast/canvas/dr...
File LayoutTests/fast/canvas/drawImage-with-valid-image.html (right):

https://codereview.chromium.org/24203002/diff/5001/LayoutTests/fast/canvas/dr...
LayoutTests/fast/canvas/drawImage-with-valid-image.html:156: </html>
On 2013/09/18 10:24:08, marja wrote:
> What's this?

Idunno. Line ending change? Not something I intentionally touched.

https://codereview.chromium.org/24203002/diff/5001/Source/bindings/scripts/de...
File Source/bindings/scripts/deprecated_code_generator_v8.pm (right):

https://codereview.chromium.org/24203002/diff/5001/Source/bindings/scripts/de...
Source/bindings/scripts/deprecated_code_generator_v8.pm:2096: $code .= "       
throwTypeError(ExceptionMessages::failedToExecute(\"$name\", \"$implClassName\",
\"$leastNumMandatoryParams argument" . ($leastNumMandatoryParams > 1 ? "s" : "")
 . " required, but only \" + String::number(args.Length()) + \" present.\"),
args.GetIsolate());\n";
On 2013/09/18 10:24:08, marja wrote:
> Would it make sense to add a func to ExceptionMessages which produces a string
> like:
> 
> "X argument(s) required but only Y present."
> 
> so that not all the places would need to construct the detail string
themselves?

I've added it, but I'm not sure it makes sense. Take a look and let me know what
you think.

[marja, 2013-09-18 11:23:50]

lgtm

https://codereview.chromium.org/24203002/diff/5001/Source/bindings/scripts/de...
File Source/bindings/scripts/deprecated_code_generator_v8.pm (right):

https://codereview.chromium.org/24203002/diff/5001/Source/bindings/scripts/de...
Source/bindings/scripts/deprecated_code_generator_v8.pm:2096: $code .= "       
throwTypeError(ExceptionMessages::failedToExecute(\"$name\", \"$implClassName\",
\"$leastNumMandatoryParams argument" . ($leastNumMandatoryParams > 1 ? "s" : "")
 . " required, but only \" + String::number(args.Length()) + \" present.\"),
args.GetIsolate());\n";
I like this version a lot better, merely the distribution of the "argument vs.
argumentS" logic in many places was hurting my brain. :)

[commit-bot: I haz the power, 2013-09-18 11:37:43]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/24203002/13001

[commit-bot: I haz the power, 2013-09-18 13:16:04]

Retried try job too often on linux_blink_rel for step(s) webkit_tests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

[Mike West, 2013-09-18 13:20:35]

On 2013/09/18 13:16:04, I haz the power (commit-bot) wrote:
> Retried try job too often on linux_blink_rel for step(s) webkit_tests
>
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blin...

svg/dom/SVGStringList-basics.xhtml has a slight difference in the scrollbar
because a line of the results now wraps. I have no idea why this is an image
test. :(

NeedsRebaseline to the rescue (I love you, Ojan!)!

[commit-bot: I haz the power, 2013-09-18 13:30:41]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mkwst@chromium.org/24203002/28001

[commit-bot: I haz the power, 2013-09-18 14:54:51]

Change committed as 157966