Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(345)

Unified Diff: Source/bindings/v8/V8ThrowException.h

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: NeedsRebaseline Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/ExceptionMessages.cpp ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8ThrowException.h
diff --git a/Source/bindings/v8/V8ThrowException.h b/Source/bindings/v8/V8ThrowException.h
index d3d8401b73065d1e2804acbde3adb5cd4bc577ca..ac996e8369481abf78c4472e0dfcb33b1f5348d4 100644
--- a/Source/bindings/v8/V8ThrowException.h
+++ b/Source/bindings/v8/V8ThrowException.h
@@ -68,6 +68,7 @@ public:
static v8::Handle<v8::Value> createTypeError(const String&, v8::Isolate*);
static v8::Handle<v8::Value> throwTypeError(const String&, v8::Isolate*);
+ // FIXME: Kill this once we kill all the callsites, since we want to pass in useful information as a string.
static v8::Handle<v8::Value> throwNotEnoughArgumentsError(v8::Isolate*);
};
« no previous file with comments | « Source/bindings/v8/ExceptionMessages.cpp ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698