LayoutTests/fast/js/resources/select-options-remove.js - Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: LayoutTests/fast/js/resources/select-options-remove.js

Issue 24203002: Improve generated "Not enough arguments." TypeError exceptions. (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: NeedsRebaseline Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/forms/setCustomValidity-arguments-expected.txt ('k') | LayoutTests/fast/js/select-options-remove-expected.txt » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: LayoutTests/fast/js/resources/select-options-remove.js

diff --git a/LayoutTests/fast/js/resources/select-options-remove.js b/LayoutTests/fast/js/resources/select-options-remove.js

index fa112681a67eb92ebf9ef1e110f8e84ef111993f..609695a36b511529619e57057c401109490b64d8 100644

--- a/LayoutTests/fast/js/resources/select-options-remove.js

+++ b/LayoutTests/fast/js/resources/select-options-remove.js

@@ -67,7 +67,7 @@ shouldBe("select1.selectedIndex", "-1");

debug("");

debug("1.10 Remove no args from empty Options");

-shouldThrow("select1.options.remove()", "'TypeError: Not enough arguments'");

+shouldThrow("select1.options.remove()", '"TypeError: Failed to execute \'remove\' on \'HTMLOptionsCollection\': 1 argument required, but only 0 present."');

shouldBe("select1.options.length", "0");

shouldBe("select1.selectedIndex", "-1");

debug("");

@@ -194,7 +194,7 @@ shouldBe("select2.options[0].value", "'K'");

debug("");

debug("2.11 Remove no args from non-empty Options");

-shouldThrow("select2.options.remove()", "'TypeError: Not enough arguments'");

+shouldThrow("select2.options.remove()", '"TypeError: Failed to execute \'remove\' on \'HTMLOptionsCollection\': 1 argument required, but only 0 present."');

shouldBe("select2.options.length", "6");

shouldBe("select2.selectedIndex", "4");

shouldBe("select2.options[0].value", "'K'");