[Cleanup] Rename WindowSettings to WindowState

Rename WindowSettings to WindowState
Move window control methods from window_util.h to WindowState
Removed property_util which is no longer necessary.

BUG=272460
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=224288

[James Cook, 2013-09-18 20:44:16]

Overall, I like the approach.

And wow, this is a big patch. :-)

https://codereview.chromium.org/24108003/diff/31001/ash/system/tray/tray_back...
File ash/system/tray/tray_background_view.cc (left):

https://codereview.chromium.org/24108003/diff/31001/ash/system/tray/tray_back...
ash/system/tray/tray_background_view.cc:19: #include "ash/wm/property_util.h"
Nice that you were able to clean up all of these.

https://codereview.chromium.org/24108003/diff/31001/ash/test/test_shell_deleg...
File ash/test/test_shell_delegate.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/test/test_shell_deleg...
ash/test/test_shell_delegate.cc:71: wm::WindowState* window_state =
wm::GetActiveWindowState();
nit: Are you sure you want to provide GetActiveWindowState(), which does two
actions in one call?  I don't think it would be that bad to keep
GetActiveWindow() and call window->GetWindowState()->ToggleMaximized().

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
File ash/wm/base_layout_manager.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:95: window_state->Unminimize();
Nice, much easier to read

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:156: if (window_state &&
window_state->IsMinimized() &&
Do you need to check window_state?  I thought GetWindowState() created it if
needed.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:175: wm::WindowState* window_state,
Mostly a question: Since you can get the WindowState from the window, and you
use window() extensively below, do you think it would be clearer to keep the
signature as: ShowStateChanged(aura::Window* window, ...)?  Or are you trying to
push people toward the Ash wrapper of the window?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:224: wm::WindowState* window_state,
Same question as above

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
File ash/wm/custom_frame_view_ash_unittest.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
ash/wm/custom_frame_view_ash_unittest.cc:482: wm::WindowState* window_state
=wm::GetWindowState(window);
space after =

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
ash/wm/custom_frame_view_ash_unittest.cc:705: wm::WindowState* window_state
=wm::GetWindowState(window);
space after =

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
ash/wm/custom_frame_view_ash_unittest.cc:731: wm::WindowState* controller =
wm::GetWindowState(window);
optional: controller -> window_state?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/dock/docked_window...
File ash/wm/dock/docked_window_layout_manager.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/dock/docked_window...
ash/wm/dock/docked_window_layout_manager.cc:495: void
DockedWindowLayoutManager::MinimizeDockedWindow(aura::Window* window) {
Good idea renaming these

https://codereview.chromium.org/24108003/diff/31001/ash/wm/toplevel_window_ev...
File ash/wm/toplevel_window_event_handler.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/toplevel_window_ev...
ash/wm/toplevel_window_event_handler.cc:119: if (key ==
aura::client::kShowStateKey &&
Not for this CL, but I wonder WindowState should provide notifications/observer
for show state changes. In particular, if we implement snap states in
WindowState then we might need WindowState to do notifications, such as for
left-snap changing to right-snap.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_properties.h
File ash/wm/window_properties.h (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_properties....
ash/wm/window_properties.h:47: extern const
aura::WindowProperty<wm::WindowState*>* const kWindowStateKey;
nit: Document this?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_resizer.h#n...
ash/wm/window_resizer.h:74: wm::WindowState* window_state;
Do we need to store this and |window| separately?  While it's not likely, I'm
worried that they might get out of sync.  Maybe just store |window| and look up
WindowState when needed?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc
File ash/wm/window_state.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:74: bool WindowState::CanMinimize() const {
I like how all the Ash-specific logic for this type of thing is in this one
file.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:120:
window_->GetProperty(aura::client::kRestoreShowStateKey));
Do we care what happens if this property doesn't exist?  It looks it would set
to SHOW_STATE_DEFAULT - would we prefer SHOW_STATE_NORMAL?  Or does it not
matter?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:163: return
*window_->GetProperty(aura::client::kRestoreBoundsKey);
Should this check if kRestoreBoundsKey exists?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h
File ash/wm/window_state.h (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:26: // behavior.
Given that this class is going to be a core piece of window management on Ash, I
would write a little more about why the class exists and how to use it.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:36: static bool
IsMaximizedOrFullscreenState(ui::WindowShowState state);
Does this need to be part of the API for this class?  I wonder if callers to
this should just do the || themselves, since it doesn't need any internal
WindowState data.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:50: // Returns true if the window is maximzied.
maximzied -> maximized.  Or just delete all these "Returns true if" comments and
just use one for the whole section -- I think it's obvious enough from the names
what these functions do.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:57: bool IsMaximizedOrFullscreen() const;
Do we really need this API?  Callers can do an ||.

(Sorry to be picky about this stuff, but since this is a core class in Ash I
think the API should be as minimal as possible.)

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:60: bool IsNormal() const;
This probably needs more explanation or a better name. I can't tell from here is
"normal" means "restored", or ShowState = default, or window-type = normal (vs.
panel)

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:87: void Normalize();
What does this do?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:207: };
Overall, I like having all this information in one place. Nice.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
File ash/wm/workspace/workspace_event_handler.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
ash/wm/workspace/workspace_event_handler.cc:140: wm::WindowState* target,
Are you sure you want to change target to a WindowState rather than a Window?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
ash/wm/workspace/workspace_window_resizer.cc:894: #if 0
Did you mean to include this?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace_controll...
File ash/wm/workspace_controller_unittest.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace_controll...
ash/wm/workspace_controller_unittest.cc:965: wm::WindowState* controller1 =
controller1 -> window1_state to be consistent with other test below

[oshima, 2013-09-19 01:52:01]

https://codereview.chromium.org/24108003/diff/31001/ash/test/test_shell_deleg...
File ash/test/test_shell_delegate.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/test/test_shell_deleg...
ash/test/test_shell_delegate.cc:71: wm::WindowState* window_state =
wm::GetActiveWindowState();
On 2013/09/18 20:44:17, James Cook wrote:
> nit: Are you sure you want to provide GetActiveWindowState(), which does two
> actions in one call?  I don't think it would be that bad to keep
> GetActiveWindow() and call window->GetWindowState()->ToggleMaximized().

I added because most cases you get active window, you ends up getting
window_state.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
File ash/wm/base_layout_manager.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:156: if (window_state &&
window_state->IsMinimized() &&
On 2013/09/18 20:44:17, James Cook wrote:
> Do you need to check window_state?  I thought GetWindowState() created it if
> needed.

gained_ative may be NULL, in which case, GetWindowState returns NULL.

I'm accepting NULL in GetWindowState to avoid the pattern like

if (window) {
   wm::WindowState* window_state = wm::GetWindowState(window);
   if (window_state->IsFoo()) {
   }
}

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:175: wm::WindowState* window_state,
On 2013/09/18 20:44:17, James Cook wrote:
> Mostly a question: Since you can get the WindowState from the window, and you
> use window() extensively below, do you think it would be clearer to keep the
> signature as: ShowStateChanged(aura::Window* window, ...)?  Or are you trying
to
> push people toward the Ash wrapper of the window?

I'm using
aura::Window* window = window_state->window();

where I feel there are too many window_state->window(). I prefer this
way because window_state->window() is cheap. Also
kRestoreShowStateKey will be gone and replaced with WindowState property
(this is ash only).

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
File ash/wm/custom_frame_view_ash_unittest.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
ash/wm/custom_frame_view_ash_unittest.cc:482: wm::WindowState* window_state
=wm::GetWindowState(window);
On 2013/09/18 20:44:17, James Cook wrote:
> space after =

Done.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
ash/wm/custom_frame_view_ash_unittest.cc:705: wm::WindowState* window_state
=wm::GetWindowState(window);
On 2013/09/18 20:44:17, James Cook wrote:
> space after =

Done.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/custom_frame_view_...
ash/wm/custom_frame_view_ash_unittest.cc:731: wm::WindowState* controller =
wm::GetWindowState(window);
On 2013/09/18 20:44:17, James Cook wrote:
> optional: controller -> window_state?
This test is gone on tot.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/toplevel_window_ev...
File ash/wm/toplevel_window_event_handler.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/toplevel_window_ev...
ash/wm/toplevel_window_event_handler.cc:119: if (key ==
aura::client::kShowStateKey &&
On 2013/09/18 20:44:17, James Cook wrote:
> Not for this CL, but I wonder WindowState should provide
notifications/observer
> for show state changes. In particular, if we implement snap states in
> WindowState then we might need WindowState to do notifications, such as for
> left-snap changing to right-snap.

Yes, I'll look into if we can change such that only WindowState listens to 
ShowStateChange, and have more explicit Obsever for ShowState change in ash.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_properties.h
File ash/wm/window_properties.h (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_properties....
ash/wm/window_properties.h:47: extern const
aura::WindowProperty<wm::WindowState*>* const kWindowStateKey;
On 2013/09/18 20:44:17, James Cook wrote:
> nit: Document this?

Done.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_resizer.h
File ash/wm/window_resizer.h (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_resizer.h#n...
ash/wm/window_resizer.h:74: wm::WindowState* window_state;
On 2013/09/18 20:44:17, James Cook wrote:
> Do we need to store this and |window| separately?  While it's not likely, I'm
> worried that they might get out of sync.  Maybe just store |window| and look
up
> WindowState when needed?

I'll remove window in separate CL as CL is already too big. See
my comment for the reason why I prefer window_state. Added todo.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc
File ash/wm/window_state.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:120:
window_->GetProperty(aura::client::kRestoreShowStateKey));
On 2013/09/18 20:44:17, James Cook wrote:
> Do we care what happens if this property doesn't exist?  It looks it would set
> to SHOW_STATE_DEFAULT - would we prefer SHOW_STATE_NORMAL?  Or does it not
> matter?

I'm not sure. This is what we are doing right now.
XXXLayoutManager::UpdateBoundsfromShowState treat them as same,
so this is probably expected.

I don't know the history, but I believe SHOW_STATE_DEFAULT is meant
for session restore, and not for WM so maybe we should clean this up at some
point.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:163: return
*window_->GetProperty(aura::client::kRestoreBoundsKey);
On 2013/09/18 20:44:17, James Cook wrote:
> Should this check if kRestoreBoundsKey exists?

Another option is to return empty rect, but it may result in
bad behavior. I think we generally prefer to fail rather than
hiding. If you feel strongly about it, I can fallback to empty rect
on release build. Let me know.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h
File ash/wm/window_state.h (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:26: // behavior.
On 2013/09/18 20:44:17, James Cook wrote:
> Given that this class is going to be a core piece of window management on Ash,
I
> would write a little more about why the class exists and how to use it.

Done.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:36: static bool
IsMaximizedOrFullscreenState(ui::WindowShowState state);
On 2013/09/18 20:44:17, James Cook wrote:
> Does this need to be part of the API for this class?  I wonder if callers to
> this should just do the || themselves, since it doesn't need any internal
> WindowState data.

I added here because this class has IsMaximizedOrFullscreen() (which has
surprisingly many usages),
and to make it clear that they're using the same logic. It may be 
simpler this case, but this make it clear they're using the same logic.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:50: // Returns true if the window is maximzied.
On 2013/09/18 20:44:17, James Cook wrote:
> maximzied -> maximized.  Or just delete all these "Returns true if" comments
and
> just use one for the whole section -- I think it's obvious enough from the
names
> what these functions do.

I'm glad you wanted remove them. I agree :)

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:57: bool IsMaximizedOrFullscreen() const;
On 2013/09/18 20:44:17, James Cook wrote:
> Do we really need this API?  Callers can do an ||.
> 
> (Sorry to be picky about this stuff, but since this is a core class in Ash I
> think the API should be as minimal as possible.)

I found that this condition is used many places (9), which convinced me
that this is important enough for ash to have it. There are opposite condition
(! && !. ) and this makes them easy to read.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:60: bool IsNormal() const;
On 2013/09/18 20:44:17, James Cook wrote:
> This probably needs more explanation or a better name. I can't tell from here
is
> "normal" means "restored", or ShowState = default, or window-type = normal
(vs.
> panel)

Changed to NormalShowState. I'll look into if we can eliminate default usage.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.h#new...
ash/wm/window_state.h:87: void Normalize();
On 2013/09/18 20:44:17, James Cook wrote:
> What does this do?

Thank you for asking. This is same as Restore() and can be removed. :)

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
File ash/wm/workspace/workspace_event_handler.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
ash/wm/workspace/workspace_event_handler.cc:140: wm::WindowState* target,
On 2013/09/18 20:44:17, James Cook wrote:
> Are you sure you want to change target to a WindowState rather than a Window?

how does it look to you now?

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
File ash/wm/workspace/workspace_window_resizer.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
ash/wm/workspace/workspace_window_resizer.cc:894: #if 0
On 2013/09/18 20:44:17, James Cook wrote:
> Did you mean to include this?

Done.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace_controll...
File ash/wm/workspace_controller_unittest.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace_controll...
ash/wm/workspace_controller_unittest.cc:965: wm::WindowState* controller1 =
On 2013/09/18 20:44:17, James Cook wrote:
> controller1 -> window1_state to be consistent with other test below

Done.

[James Cook, 2013-09-19 03:49:52]

LGTM with nits.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
File ash/wm/base_layout_manager.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/base_layout_manage...
ash/wm/base_layout_manager.cc:175: wm::WindowState* window_state,
On 2013/09/19 01:52:01, oshima wrote:
> On 2013/09/18 20:44:17, James Cook wrote:
> > Mostly a question: Since you can get the WindowState from the window, and
you
> > use window() extensively below, do you think it would be clearer to keep the
> > signature as: ShowStateChanged(aura::Window* window, ...)?  Or are you
trying
> to
> > push people toward the Ash wrapper of the window?
> 
> I'm using
> aura::Window* window = window_state->window();
> 
> where I feel there are too many window_state->window(). I prefer this
> way because window_state->window() is cheap. Also
> kRestoreShowStateKey will be gone and replaced with WindowState property
> (this is ash only).

Good point that window_state->window() is much cheaper than
window->GetWindowState(). sgtm

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc
File ash/wm/window_state.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/window_state.cc#ne...
ash/wm/window_state.cc:163: return
*window_->GetProperty(aura::client::kRestoreBoundsKey);
On 2013/09/19 01:52:01, oshima wrote:
> On 2013/09/18 20:44:17, James Cook wrote:
> > Should this check if kRestoreBoundsKey exists?
> 
> Another option is to return empty rect, but it may result in
> bad behavior. I think we generally prefer to fail rather than
> hiding. If you feel strongly about it, I can fallback to empty rect
> on release build. Let me know.

Failing sounds fine here, especially since the old code did that.

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
File ash/wm/workspace/workspace_event_handler.cc (right):

https://codereview.chromium.org/24108003/diff/31001/ash/wm/workspace/workspac...
ash/wm/workspace/workspace_event_handler.cc:140: wm::WindowState* target,
On 2013/09/19 01:52:01, oshima wrote:
> On 2013/09/18 20:44:17, James Cook wrote:
> > Are you sure you want to change target to a WindowState rather than a
Window?
> 
> how does it look to you now?

Better, thanks.

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h
File ash/wm/window_state.h (right):

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h#new...
ash/wm/window_state.h:28: // Maximize, minimize, snap sizing etc) should be
added here instead
Maximize -> maximize

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h#new...
ash/wm/window_state.h:30: // window)|) nor using aura Window property.
nor -> or

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h#new...
ash/wm/window_state.h:32: // |wm::GetWindowState|, and deleted when the window
is deleted.
You might also mention here your design principle that we prefer passing
WindowState* to functions that need both a Window and a WindowState because
window_state->window() is cheaper than wm::GetWindowState(window).

https://codereview.chromium.org/24108003/diff/40001/ash/wm/workspace/snap_siz...
File ash/wm/workspace/snap_sizer.cc (right):

https://codereview.chromium.org/24108003/diff/40001/ash/wm/workspace/snap_siz...
ash/wm/workspace/snap_sizer.cc:176: internal::SnapSizer
sizer(window_state->window(), gfx::Point(), edge,
nit: Maybe just use |window|?

[oshima, 2013-09-19 17:44:04]

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h
File ash/wm/window_state.h (right):

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h#new...
ash/wm/window_state.h:28: // Maximize, minimize, snap sizing etc) should be
added here instead
On 2013/09/19 03:49:53, James Cook wrote:
> Maximize -> maximize

Done.

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h#new...
ash/wm/window_state.h:30: // window)|) nor using aura Window property.
On 2013/09/19 03:49:53, James Cook wrote:
> nor -> or

Done.

https://codereview.chromium.org/24108003/diff/40001/ash/wm/window_state.h#new...
ash/wm/window_state.h:32: // |wm::GetWindowState|, and deleted when the window
is deleted.
On 2013/09/19 03:49:53, James Cook wrote:
> You might also mention here your design principle that we prefer passing
> WindowState* to functions that need both a Window and a WindowState because
> window_state->window() is cheaper than wm::GetWindowState(window).

Done.

https://codereview.chromium.org/24108003/diff/40001/ash/wm/workspace/snap_siz...
File ash/wm/workspace/snap_sizer.cc (right):

https://codereview.chromium.org/24108003/diff/40001/ash/wm/workspace/snap_siz...
ash/wm/workspace/snap_sizer.cc:176: internal::SnapSizer
sizer(window_state->window(), gfx::Point(), edge,
On 2013/09/19 03:49:53, James Cook wrote:
> nit: Maybe just use |window|?

Done.

[oshima, 2013-09-19 17:46:42]

sky -> chrome/browser/ 

derat,flackr,varkha -> FYI

[sky, 2013-09-19 20:39:21]

LGTM

[commit-bot: I haz the power, 2013-09-19 21:22:14]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/24108003/106001

[commit-bot: I haz the power, 2013-09-19 22:40:16]

Retried try job too often on linux_chromeos for step(s) ash_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_chro...

[commit-bot: I haz the power, 2013-09-20 00:29:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/oshima@chromium.org/24108003/42001

[commit-bot: I haz the power, 2013-09-20 04:36:39]

Change committed as 224288