Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Side by Side Diff: chrome/browser/ui/ash/chrome_shell_delegate_browsertest.cc

Issue 24108003: [Cleanup] Rename WindowSettings to WindowState (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: rebase fix Created 7 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/ui/ash/chrome_shell_delegate.h" 5 #include "chrome/browser/ui/ash/chrome_shell_delegate.h"
6 6
7 #include "apps/native_app_window.h" 7 #include "apps/native_app_window.h"
8 #include "apps/shell_window.h" 8 #include "apps/shell_window.h"
9 #include "ash/ash_switches.h" 9 #include "ash/ash_switches.h"
10 #include "ash/shell.h" 10 #include "ash/shell.h"
11 #include "ash/shell_delegate.h" 11 #include "ash/shell_delegate.h"
12 #include "ash/wm/window_properties.h" 12 #include "ash/wm/window_properties.h"
13 #include "ash/wm/window_util.h" 13 #include "ash/wm/window_state.h"
14 #include "base/command_line.h" 14 #include "base/command_line.h"
15 #include "chrome/browser/apps/app_browsertest_util.h" 15 #include "chrome/browser/apps/app_browsertest_util.h"
16 #include "chrome/browser/ui/browser.h" 16 #include "chrome/browser/ui/browser.h"
17 #include "chrome/browser/ui/browser_commands.h" 17 #include "chrome/browser/ui/browser_commands.h"
18 #include "chrome/browser/ui/browser_finder.h" 18 #include "chrome/browser/ui/browser_finder.h"
19 #include "chrome/browser/ui/browser_window.h" 19 #include "chrome/browser/ui/browser_window.h"
20 #include "chrome/browser/ui/immersive_fullscreen_configuration.h" 20 #include "chrome/browser/ui/immersive_fullscreen_configuration.h"
21 #include "chrome/test/base/in_process_browser_test.h" 21 #include "chrome/test/base/in_process_browser_test.h"
22 #include "ui/aura/client/aura_constants.h" 22 #include "ui/aura/client/aura_constants.h"
23 23
(...skipping 12 matching lines...) Expand all
36 } 36 }
37 37
38 } // namespace 38 } // namespace
39 39
40 typedef InProcessBrowserTest ChromeShellDelegateBrowserTest; 40 typedef InProcessBrowserTest ChromeShellDelegateBrowserTest;
41 41
42 // Confirm that toggling window miximized works properly 42 // Confirm that toggling window miximized works properly
43 IN_PROC_BROWSER_TEST_F(ChromeShellDelegateBrowserTest, ToggleMaximized) { 43 IN_PROC_BROWSER_TEST_F(ChromeShellDelegateBrowserTest, ToggleMaximized) {
44 ash::ShellDelegate* shell_delegate = ash::Shell::GetInstance()->delegate(); 44 ash::ShellDelegate* shell_delegate = ash::Shell::GetInstance()->delegate();
45 ASSERT_TRUE(shell_delegate); 45 ASSERT_TRUE(shell_delegate);
46 aura::Window* window = ash::wm::GetActiveWindow(); 46 ash::wm::WindowState* window_state = ash::wm::GetActiveWindowState();
47 ASSERT_TRUE(window); 47 ASSERT_TRUE(window_state);
48 48
49 // When not in fullscreen, ShellDelegate::ToggleMaximized toggles Maximized. 49 // When not in fullscreen, ShellDelegate::ToggleMaximized toggles Maximized.
50 EXPECT_FALSE(ash::wm::IsWindowMaximized(window)); 50 EXPECT_FALSE(window_state->IsMaximized());
51 shell_delegate->ToggleMaximized(); 51 shell_delegate->ToggleMaximized();
52 EXPECT_TRUE(ash::wm::IsWindowMaximized(window)); 52 EXPECT_TRUE(window_state->IsMaximized());
53 shell_delegate->ToggleMaximized(); 53 shell_delegate->ToggleMaximized();
54 EXPECT_FALSE(ash::wm::IsWindowMaximized(window)); 54 EXPECT_FALSE(window_state->IsMaximized());
55 55
56 // When in fullscreen ShellDelegate::ToggleMaximized gets out of fullscreen. 56 // When in fullscreen ShellDelegate::ToggleMaximized gets out of fullscreen.
57 EXPECT_FALSE(ash::wm::IsWindowFullscreen(window)); 57 EXPECT_FALSE(window_state->IsFullscreen());
58 Browser* browser = chrome::FindBrowserWithWindow(window); 58 Browser* browser = chrome::FindBrowserWithWindow(window_state->window());
59 ASSERT_TRUE(browser); 59 ASSERT_TRUE(browser);
60 chrome::ToggleFullscreenMode(browser); 60 chrome::ToggleFullscreenMode(browser);
61 EXPECT_TRUE(ash::wm::IsWindowFullscreen(window)); 61 EXPECT_TRUE(window_state->IsFullscreen());
62 shell_delegate->ToggleMaximized(); 62 shell_delegate->ToggleMaximized();
63 EXPECT_FALSE(ash::wm::IsWindowFullscreen(window)); 63 EXPECT_FALSE(window_state->IsFullscreen());
64 EXPECT_FALSE(ash::wm::IsWindowMaximized(window)); 64 EXPECT_FALSE(window_state->IsMaximized());
65 shell_delegate->ToggleMaximized(); 65 shell_delegate->ToggleMaximized();
66 EXPECT_FALSE(ash::wm::IsWindowFullscreen(window)); 66 EXPECT_FALSE(window_state->IsFullscreen());
67 EXPECT_TRUE(ash::wm::IsWindowMaximized(window)); 67 EXPECT_TRUE(window_state->IsMaximized());
68 } 68 }
69 69
70 // Confirm that toggling window fullscren works properly. 70 // Confirm that toggling window fullscren works properly.
71 IN_PROC_BROWSER_TEST_F(ChromeShellDelegateBrowserTest, ToggleFullscreen) { 71 IN_PROC_BROWSER_TEST_F(ChromeShellDelegateBrowserTest, ToggleFullscreen) {
72 ash::ShellDelegate* shell_delegate = ash::Shell::GetInstance()->delegate(); 72 ash::ShellDelegate* shell_delegate = ash::Shell::GetInstance()->delegate();
73 ASSERT_TRUE(shell_delegate); 73 ASSERT_TRUE(shell_delegate);
74 74
75 // 1) ToggleFullscreen() should toggle whether a tabbed browser window is in 75 // 1) ToggleFullscreen() should toggle whether a tabbed browser window is in
76 // immersive fullscreen. 76 // immersive fullscreen.
77 ASSERT_TRUE(browser()->is_type_tabbed()); 77 ASSERT_TRUE(browser()->is_type_tabbed());
(...skipping 104 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 182
183 shell_delegate->ToggleFullscreen(); 183 shell_delegate->ToggleFullscreen();
184 EXPECT_TRUE(app_window->IsFullscreen()); 184 EXPECT_TRUE(app_window->IsFullscreen());
185 185
186 shell_delegate->ToggleFullscreen(); 186 shell_delegate->ToggleFullscreen();
187 EXPECT_FALSE(app_window->IsMaximized()); 187 EXPECT_FALSE(app_window->IsMaximized());
188 EXPECT_FALSE(app_window->IsFullscreen()); 188 EXPECT_FALSE(app_window->IsFullscreen());
189 189
190 CloseShellWindow(shell_window); 190 CloseShellWindow(shell_window);
191 } 191 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698