[Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive()

[Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive()

The function tests whether web contents modal dialogs are active, rather
than if they are actually showing. This updates the name accordingly
and resolves the TODO.

BUG=157161
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=222289

[sky, 2013-09-09 23:30:06]

LGTM

[commit-bot: I haz the power, 2013-09-10 00:12:09]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/23815006/1

[commit-bot: I haz the power, 2013-09-10 00:12:14]

Failed to apply patch for
chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
  Hunk #1 FAILED at 372.
  1 out of 1 hunk FAILED -- saving rejects to file
chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc.rej

Patch:       chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
Index: chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
diff --git a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
index
b9ad12f6a8568d0a785eb19c571c45294f441f9b..da2545ff734865d36cd0e9a645c5e4f9af3417f0
100644
--- a/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
+++ b/chrome/browser/ui/views/tabs/browser_tab_strip_controller.cc
@@ -372,7 +372,7 @@ bool
BrowserTabStripController::IsTabShowingWebViewModalDialog(int index) {
       WebContentsModalDialogManager::FromWebContents(
           model_->GetWebContentsAt(index));
   return contents_modal_dialog_manager &&
-      contents_modal_dialog_manager->IsShowingDialog();
+      contents_modal_dialog_manager->IsDialogActive();
 }
 
 void BrowserTabStripController::OnStartedDraggingTabs() {

[commit-bot: I haz the power, 2013-09-10 00:52:32]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/23815006/6001

[commit-bot: I haz the power, 2013-09-10 01:24:33]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 01:50:28]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/23815006/6001

[commit-bot: I haz the power, 2013-09-10 01:59:25]

Sorry for I got bad news for ya.
Compile failed with a clobber build on mac_rel.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-09-10 04:56:10]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/23815006/6001

[commit-bot: I haz the power, 2013-09-10 07:09:44]

Retried try job too often on mac_rel for step(s) telemetry_unittests
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=mac_rel&nu...

[commit-bot: I haz the power, 2013-09-10 16:07:56]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/wittman@chromium.org/23815006/6001

[commit-bot: I haz the power, 2013-09-10 17:19:19]

Change committed as 222289