[Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive()

components/web_modal/web_contents_modal_dialog_manager_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include <map>
 
 #include "base/memory/scoped_ptr.h"
 #include "components/web_modal/native_web_contents_modal_dialog_manager.h"
 #include "components/web_modal/web_contents_modal_dialog_manager.h"
 #include "components/web_modal/web_contents_modal_dialog_manager_delegate.h"
@@ skipping 154 matching lines @@
 // Test that the dialog is shown immediately when the delegate indicates the web
 // contents is visible.
 TEST_F(WebContentsModalDialogManagerTest, WebContentsVisible) {
   // Dialog should be shown while WebContents is visible.
   const NativeWebContentsModalDialog dialog1 = MakeFakeDialog();
 
   manager->ShowDialog(dialog1);
 
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::SHOWN,
             native_manager->GetDialogState(dialog1));
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
 }
 
 // Test that the dialog is not shown immediately when the delegate indicates the
 // web contents is not visible.
 TEST_F(WebContentsModalDialogManagerTest, WebContentsNotVisible) {
   // Dialog should not be shown while WebContents is not visible.
   delegate->set_web_contents_visible(false);
 
   const NativeWebContentsModalDialog dialog1 = MakeFakeDialog();
 
   manager->ShowDialog(dialog1);
 
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::NOT_SHOWN,
             native_manager->GetDialogState(dialog1));
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
 }
 
 // Test that only the first of multiple dialogs is shown.
 TEST_F(WebContentsModalDialogManagerTest, ShowDialogs) {
   const NativeWebContentsModalDialog dialog1 = MakeFakeDialog();
   const NativeWebContentsModalDialog dialog2 = MakeFakeDialog();
   const NativeWebContentsModalDialog dialog3 = MakeFakeDialog();
 
   manager->ShowDialog(dialog1);
@@ skipping 10 matching lines @@
 }
 
 // Test that the dialog is shown/hidden on
 // NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED.
 TEST_F(WebContentsModalDialogManagerTest, VisibilityObservation) {
   const NativeWebContentsModalDialog dialog1 = MakeFakeDialog();
   bool web_contents_visible = true;
 
   manager->ShowDialog(dialog1);
 
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::SHOWN,
             native_manager->GetDialogState(dialog1));
 
   web_contents_visible = false;
   manager->Observe(content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
                    content::NotificationService::AllSources(),
                    content::Details<bool>(&web_contents_visible));
 
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::HIDDEN,
             native_manager->GetDialogState(dialog1));
 
   web_contents_visible = true;
   manager->Observe(content::NOTIFICATION_WEB_CONTENTS_VISIBILITY_CHANGED,
                    content::NotificationService::AllSources(),
                    content::Details<bool>(&web_contents_visible));
 
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::SHOWN,
             native_manager->GetDialogState(dialog1));
 }
 
 // Test that attaching an interstitial WebUI page closes dialogs configured to
 // close on interstitial WebUI.
 TEST_F(WebContentsModalDialogManagerTest, InterstitialWebUI) {
   const NativeWebContentsModalDialog dialog1 = MakeFakeDialog();
   const NativeWebContentsModalDialog dialog2 = MakeFakeDialog();
@@ skipping 25 matching lines @@
   const NativeWebContentsModalDialog dialog3 = MakeFakeDialog();
   const NativeWebContentsModalDialog dialog4 = MakeFakeDialog();
 
   manager->ShowDialog(dialog1);
   manager->ShowDialog(dialog2);
   manager->ShowDialog(dialog3);
   manager->ShowDialog(dialog4);
 
   native_manager->CloseDialog(dialog1);
 
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::CLOSED,
             native_manager->GetDialogState(dialog1));
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::SHOWN,
             native_manager->GetDialogState(dialog2));
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::NOT_SHOWN,
             native_manager->GetDialogState(dialog3));
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::NOT_SHOWN,
             native_manager->GetDialogState(dialog4));
 
   native_manager->CloseDialog(dialog3);
 
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::SHOWN,
             native_manager->GetDialogState(dialog2));
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::CLOSED,
             native_manager->GetDialogState(dialog3));
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::NOT_SHOWN,
             native_manager->GetDialogState(dialog4));
 
   native_manager->CloseDialog(dialog2);
 
-  EXPECT_TRUE(manager->IsShowingDialog());
+  EXPECT_TRUE(manager->IsDialogActive());
   EXPECT_TRUE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::CLOSED,
             native_manager->GetDialogState(dialog2));
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::SHOWN,
             native_manager->GetDialogState(dialog4));
 
   native_manager->CloseDialog(dialog4);
 
-  EXPECT_FALSE(manager->IsShowingDialog());
+  EXPECT_FALSE(manager->IsDialogActive());
   EXPECT_FALSE(delegate->web_contents_blocked());
   EXPECT_EQ(TestNativeWebContentsModalDialogManager::CLOSED,
             native_manager->GetDialogState(dialog4));
 }
 
 // Test that CloseAllDialogs does what it says.
 TEST_F(WebContentsModalDialogManagerTest, CloseAllDialogs) {
   const int kWindowCount = 4;
   for (int i = 0; i < kWindowCount; i++)
     manager->ShowDialog(MakeFakeDialog());
 
   EXPECT_EQ(0, native_manager->GetCloseCount());
 
   test_api->CloseAllDialogs();
   EXPECT_FALSE(delegate->web_contents_blocked());
-  EXPECT_FALSE(manager->IsShowingDialog());
+  EXPECT_FALSE(manager->IsDialogActive());
   EXPECT_EQ(kWindowCount, native_manager->GetCloseCount());
 }
 
 }  // namespace web_modal