components/web_modal/web_contents_modal_dialog_manager.cc - Issue 23815006: [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/web_modal/web_contents_modal_dialog_manager.cc

Issue 23815006: [Cleanup] rename WebContentsModalDialogManager::IsShowingDialog() to IsDialogActive() (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Rebase Created 7 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/web_modal/web_contents_modal_dialog_manager.h ('k') | components/web_modal/web_contents_modal_dialog_manager_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/web_modal/web_contents_modal_dialog_manager.cc

diff --git a/components/web_modal/web_contents_modal_dialog_manager.cc b/components/web_modal/web_contents_modal_dialog_manager.cc

index 949abbf4f13390196a9a534ac27ef5477a62264f..4d8aca714c59ebce1671f4c2f2aa7e7437688742 100644

--- a/components/web_modal/web_contents_modal_dialog_manager.cc

+++ b/components/web_modal/web_contents_modal_dialog_manager.cc

@@ -45,7 +45,7 @@ void WebContentsModalDialogManager::ShowDialog(

}

-bool WebContentsModalDialogManager::IsShowingDialog() const {

+bool WebContentsModalDialogManager::IsDialogActive() const {

return !child_dialogs_.empty();

}