Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(416)

Issue 23717011: DevTools: Use scriptId for resolving stack frames in console messages (Closed)

Created:
7 years, 3 months ago by vsevik
Modified:
7 years, 3 months ago
Reviewers:
pfeldman, yurys
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, do-not-use, Nils Barth (inactive), caseq+blink_chromium.org, kojih, yurys+blink_chromium.org, abarth-chromium, marja+watch_chromium.org, dglazkov+blink, devtools-reviews_chromium.org, loislo+blink_chromium.org, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org
Visibility:
Public.

Description

DevTools: Use scriptId for resolving stack frames in console messages BUG=272742 R=yurys@chromium.org, pfeldman@chromium.org Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=157129

Patch Set 1 #

Patch Set 2 : Fixed tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+132 lines, -31 lines) Patch
M LayoutTests/http/tests/inspector/console-resource-errors-expected.txt View 1 1 chunk +1 line, -1 line 0 comments Download
M LayoutTests/http/tests/inspector/console-test.js View 1 4 chunks +18 lines, -3 lines 0 comments Download
M LayoutTests/inspector/console/console-eval-scoped-expected.txt View 1 chunk +3 lines, -3 lines 0 comments Download
A LayoutTests/inspector/console/console-stack-overflow.html View 1 1 chunk +40 lines, -0 lines 0 comments Download
A LayoutTests/inspector/console/console-stack-overflow-expected.txt View 1 chunk +5 lines, -0 lines 0 comments Download
M LayoutTests/inspector/console/console-uncaught-exception-in-eval.html View 2 chunks +38 lines, -12 lines 0 comments Download
M LayoutTests/inspector/console/console-uncaught-exception-in-eval-expected.txt View 1 chunk +4 lines, -4 lines 0 comments Download
M LayoutTests/inspector/console/console-xpath-expected.txt View 1 chunk +1 line, -1 line 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.h View 1 chunk +1 line, -0 lines 0 comments Download
M Source/bindings/v8/ScriptCallStackFactory.cpp View 4 chunks +6 lines, -2 lines 0 comments Download
M Source/core/inspector/ScriptCallFrame.h View 2 chunks +3 lines, -1 line 0 comments Download
M Source/core/inspector/ScriptCallFrame.cpp View 3 chunks +4 lines, -1 line 0 comments Download
M Source/devtools/front_end/ConsoleMessage.js View 1 3 chunks +7 lines, -3 lines 0 comments Download
M Source/devtools/protocol.json View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
vsevik
Please review
7 years, 3 months ago (2013-08-30 13:59:32 UTC) #1
pfeldman
lgtm. make sure V8Initialized.cpp is happy with this change.
7 years, 3 months ago (2013-09-02 16:05:40 UTC) #2
vsevik
On 2013/09/02 16:05:40, pfeldman wrote: > lgtm. make sure V8Initialized.cpp is happy with this change. ...
7 years, 3 months ago (2013-09-03 07:14:34 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23717011/1
7 years, 3 months ago (2013-09-03 07:14:55 UTC) #4
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=3775
7 years, 3 months ago (2013-09-03 08:44:15 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vsevik@chromium.org/23717011/20001
7 years, 3 months ago (2013-09-03 14:16:03 UTC) #6
commit-bot: I haz the power
7 years, 3 months ago (2013-09-03 15:56:36 UTC) #7
Message was sent while issue was closed.
Change committed as 157129

Powered by Google App Engine
This is Rietveld 408576698